Skip to content

[firebase_messaging] Add Kotlin support in README.md. #3457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

beshr-eldebuch
Copy link

@beshr-eldebuch beshr-eldebuch commented Sep 3, 2020

Description

For new projects with Kotlin's support, the project only contains MainActivity.kt and not MainActivity.java, and as for now, README.md doesn't support it.

  • ✅ Added Kotlin support in README.md.

Related Issues

issue database.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • ✅ I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • ✅ If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • ✅ My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • ✅ All existing and new tests are passing.
  • ✅ I updated/added relevant documentation (doc comments with ///).
  • ✅ The analyzer (flutter analyze) does not report any problems on my PR.
  • ✅ I read and followed the Flutter Style Guide.
  • ✅ I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • ✅ I updated CHANGELOG.md to add a description of the change.
  • ✅ I signed the CLA.
  • ✅ I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • ✅ No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@beshr-eldebuch
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 3, 2020

1. Set name property of application in `AndroidManifest.xml`. This is typically found in `<app-name>/android/app/src/main/`.
4. Set name property of application in `AndroidManifest.xml`. This is typically found in `<app-name>/android/app/src/main/`.

```xml
<application android:name=".Application" ...>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to show from and to for people not familiar with editing AndroidManifest.xml files.

Suggested change
<application android:name=".Application" ...>
<!-- FROM -->
<application android:name="io.flutter.app.FlutterApplication" ... />
<!-- TO -->
<application android:name=".Application" ... />

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants