-
Notifications
You must be signed in to change notification settings - Fork 4k
[firebase_messaging] Add Kotlin support in README.md
.
#3457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Kotling support in README.md.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
||
1. Set name property of application in `AndroidManifest.xml`. This is typically found in `<app-name>/android/app/src/main/`. | ||
4. Set name property of application in `AndroidManifest.xml`. This is typically found in `<app-name>/android/app/src/main/`. | ||
|
||
```xml | ||
<application android:name=".Application" ...> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to show from and to for people not familiar with editing AndroidManifest.xml files.
<application android:name=".Application" ...> | |
<!-- FROM --> | |
<application android:name="io.flutter.app.FlutterApplication" ... /> | |
<!-- TO --> | |
<application android:name=".Application" ... /> |
Description
For new projects with Kotlin's support, the project only contains
MainActivity.kt
and notMainActivity.java
, and as for now,README.md
doesn't support it.README.md
.Related Issues
issue database.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?