Skip to content

docs(admob): update README.md to use kotlin instead of java #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Oct 4, 2020

Description

As mentioned in #3601, bootstrapping a Flutter app, now generates the MainActivity in Kotlin, instead of java.
This PR should update the README.md files in the firebase_admob and firebase_messaging package to show Kotlin usage instead of java.

Update: I have reverted the firebase_messaging changes in favor of #3457

Related Issues

Fix #3601

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@thatfiredev thatfiredev changed the title docs(admob, messaging): update README.md to use kotlin instead of java docs(admob): update README.md to use kotlin instead of java Oct 4, 2020
@russellwheatley
Copy link
Member

The firebase_admob plugin will be deprecated in April 2021 in favor of Google Mobile Ads SDK for Flutter.
Google Mobile Ads SDK for Flutter is a new Flutter plugin that supports more Ads formats than firebase_admob does. Google Mobile Ads SDK for Flutter currently supports loading and displaying banner, interstitial (full-screen), native ads, and rewarded video ads across AdMob and AdManager. It also supports displaying banner and native ads as Widgets as opposed to being overlayed over all app content.
We're now recommending projects currently using firebase_admob migrate to Google Mobile Ads SDK for Flutter following the instructions outlined here.
Issues with migrating or with using the new package should now be raised over on the Google Mobile Ads SDK for Flutter repository.

@firebase firebase locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📚] firebase_admob readme Android code fragments in Kotlin
3 participants