Skip to content

Conversation

klingonaston
Copy link
Contributor

@klingonaston klingonaston commented Apr 18, 2025

Motivation

This PR addresses Issue #174 in the Flashbots Contender repository. The issue pertained to [briefly describe the problem, e.g., "a race condition causing transaction misordering under high load"]. Resolving this ensures improved stability and performance of the Contender tool.​

Solution

The implemented solution involves [briefly describe the solution, e.g., "introducing a mutex to synchronize access to shared resources, thereby preventing concurrent modifications that led to the race condition"]. This change ensures that [describe the outcome, e.g., "transactions are processed in the correct order without conflicts"].

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klingonaston klingonaston deleted the feature/174-admin-command branch April 20, 2025 08:13
@zeroXbrock
Copy link
Member

hey @klingonaston just wondering why you closed this? The code looks good, would be happy to help w/ any merge conflicts.

@klingonaston klingonaston restored the feature/174-admin-command branch April 28, 2025 19:32
@klingonaston klingonaston reopened this Apr 28, 2025
@klingonaston klingonaston force-pushed the feature/174-admin-command branch from 580b9a5 to bc30acd Compare April 28, 2025 19:40
@klingonaston
Copy link
Contributor Author

@zeroXbrock sorry for the inconvenience. I was confused about the conflicts. I need help with the merge conflicts.

@zeroXbrock
Copy link
Member

@zeroXbrock sorry for the inconvenience. I was confused about the conflicts. I need help with the merge conflicts.

No problem, this one was kinda hairy, happy to handle the conflicts. Thanks for the PR!

Copy link
Member

@zeroXbrock zeroXbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so happy to finally have this -- very helpful for debugging. Thanks again @klingonaston !

@github-actions github-actions bot mentioned this pull request Jun 18, 2025
This was referenced Aug 14, 2025
This was referenced Aug 28, 2025
This was referenced Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants