Build rest of the charts even when Tracing is disabled and heatmap charts fail #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hen Tracing is disabled and heatmap charts fail
zeroXbrock
approved these changes
May 12, 2025
This was referenced May 14, 2025
Merged
This was referenced May 23, 2025
Merged
Merged
This was referenced May 30, 2025
Merged
Merged
This was referenced Jul 14, 2025
Merged
This was referenced Aug 14, 2025
Merged
Merged
This was referenced Aug 28, 2025
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solves #212
Earlier we'd stop building reports when we encountered an error while building the reports. The first report is a heat map chart of trace data, which when unavailable would halt building rest of the charts.
Solution
Earlier we'd check if no trace data was collected, we'd stop. Now if the trace data is empty, we only show that in the report for that particular chart, and build rest of the charts as usual.
PR Checklist