Skip to content

Build rest of the charts even when Tracing is disabled and heatmap charts fail #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
+10 −1
Merged

Build rest of the charts even when Tracing is disabled and heatmap charts fail #214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34400a7
Build other charts even w
arpitkarnatak May 5, 2025
577feb2
Merge branch 'main' into fix/heatmap-chart-when-trace-disabled
zeroXbrock May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion crates/cli/src/commands/report/chart/drawable_charts/heatmap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ impl HeatMapChart {
}

if updates_per_slot_per_block.is_empty() {
return Err("No trace data was collected. If transactions from the specified run landed, your target node may not support geth-style preState traces".into());
println!("No trace data was collected. If transactions from the specified run landed, your target node may not support geth-style preState traces");
}

Ok(Self {
Expand Down Expand Up @@ -139,6 +139,15 @@ impl DrawableChart for HeatMapChart {
let slot_names = self.get_hex_slots();
let matrix = self.get_matrix();

if matrix.is_empty() {
root.draw(&Text::new(
"No trace data was collected",
(0, 0),
("sans-serif", 32),
))?;
return Ok(());
}

let x_size = matrix.len();
let y_size = matrix[0].len();
let max_incidence = matrix
Expand Down
Loading