Skip to content

Add rawBytes to BarcodeValue #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

the-mars-rover
Copy link
Contributor

@bharat-biradar Hi there :)

In short, this PR adds rawBytes to the BarcodeValue class.

I'll provide some background to motivate why this would be a valuable addition. I had a requirement when scanning barcodes not encoded using UTF8. The only way I code extract valuable information from these barcodes was through accessing the raw bytes of the barcodes. Hence, I raised an issue and opened a PR on the firebase_ml_vision plugin, please see the links below for context:

Aside from myself, there are quite a few others who also wanted to see this feature go in (judging by the activity on the Issue and the PR). However, since the firebase_ml_vision was discontinued, the PR was closed and I was directed to use this plugin instead. Consequently I'd like to propose adding this feature :-)

I have tested the change on iOS and Android devices and both are working. Please let me know if there is anything I am missing or you would like me to add :-)

Also, since this is quite a small change I have not raised an issue for it, but will be happy to do so on request. Thanks in advance for your help.

@bharat-biradar
Copy link
Collaborator

@marcus-bornman Thank you for the contribution and sorry for the delay.

@bharat-biradar bharat-biradar changed the title Add rawBytes to BarcodeValue Add rawBytes to BarcodeValue Jun 9, 2021
@bharat-biradar bharat-biradar merged commit abfb0de into flutter-ml:master Jun 9, 2021
@the-mars-rover
Copy link
Contributor Author

@bharat-biradar thank you 🙏 very much appreciated.

@the-mars-rover the-mars-rover deleted the barcode-detector-raw-bytes branch June 9, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants