Engine scenario_app as a test, avoid needs-tests comment #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
keyonghan
reviewed
Dec 19, 2023
| } | ||
|
|
||
| bool _isATest(String filename) { | ||
| bool _isAFrameworkTest(String filename) { |
There was a problem hiding this comment.
Are we missing the _isAFrameworkTest definition?
There was a problem hiding this comment.
This already existed, I just renamed this from _isATest to _isAFrameworkTest since I was adding _isAnEngineTest and wanted to differentiate them.
There was a problem hiding this comment.
Was looking for this function in my local fork..! Sorry for the noise.
keyonghan
approved these changes
Dec 19, 2023
| } | ||
|
|
||
| bool _isATest(String filename) { | ||
| bool _isAFrameworkTest(String filename) { |
There was a problem hiding this comment.
Was looking for this function in my local fork..! Sorry for the noise.
jmagman
added
the
autosubmit
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat engine
scenario_appas a test and do not add needs-test comment. Example: flutter/engine#49066 (comment)Refactor tests, put all the code/test combo checks into one test to reduce boilerplate, otherwise I would have needed to add a new test for the
scenario_appcheck.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.