-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I got distracted yak shaving flutter/cocoon#3358 |
test-exempt: is a test |
Treat [engine `scenario_app`](https://github.com/flutter/engine/tree/main/testing/scenario_app) as a test and do not add needs-test comment. Example: flutter/engine#49066 (comment) Refactor tests, put all the code/test combo checks into one test to reduce boilerplate, otherwise I would have needed to add a new test for the `scenario_app` check.
…140527) flutter/engine@1b1b2a1...737e6f8 2023-12-21 [email protected] Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343) 2023-12-21 [email protected] Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336) 2023-12-21 [email protected] Turn on scenario app screenshots (flutter/engine#49066) 2023-12-21 [email protected] Revert onrender change (flutter/engine#49333) 2023-12-21 [email protected] [web] autofocus in new routes (flutter/engine#47727) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#140527) flutter/engine@1b1b2a1...737e6f8 2023-12-21 [email protected] Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343) 2023-12-21 [email protected] Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336) 2023-12-21 [email protected] Turn on scenario app screenshots (flutter/engine#49066) 2023-12-21 [email protected] Revert onrender change (flutter/engine#49333) 2023-12-21 [email protected] [web] autofocus in new routes (flutter/engine#47727) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Save a recording/screenshot to the uploaded xcresult when a Scenario test fails.
No more errant spew as reported in #19668 when this was originally turned off.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761683198070320113/+/u/test:_Scenario_App_Integration_Tests__3_/stdout
Fixes flutter/flutter#140192
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.