onBeginFrame JNI #18866

cg021 · 2020-06-06T19:14:25Z

Description

Add JNI method onBeginFrame for hybrid composition in the engine.

Related Issues

flutter/flutter#58288

Tests

I added the following tests:

onBeginFrame__callsPlatformViewsController

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

blasten · 2020-06-11T21:47:27Z

shell/platform/android/jni/platform_view_android_jni.h

@@ -130,6 +130,13 @@ class PlatformViewAndroidJNI {
                                                int y,
                                                int width,
                                                int height) = 0;
+  //----------------------------------------------------------------------------
+  /// @brief      Initiates the initialization of a frame if using hybrid 


nit: Initiates a frame

blasten · 2020-06-11T21:48:13Z

ci/licenses_golden/licenses_flutter

@@ -388,6 +388,7 @@ FILE: ../../../flutter/lib/ui/text/paragraph_builder.cc
 FILE: ../../../flutter/lib/ui/text/paragraph_builder.h
 FILE: ../../../flutter/lib/ui/text/text_box.h
 FILE: ../../../flutter/lib/ui/ui.dart
+FILE: ../../../flutter/lib/ui/ui_benchmarks.cc


this file still contains changes

blasten

LGTM

* 141ee78 Roll Dart SDK from 2b917f5b6a0e to 0fab083e1c2b (15 revisions) (flutter/engine#18974) * f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events (flutter/engine#18979) * 4dabac9 Roll Fuchsia Linux SDK from 8AiUM... to ThzHh... (flutter/engine#18976) * 50cae02 Reland: Add RAII wrapper for EGLSurface (flutter/engine#18977) * db7f226 Include the memory header as unique_ptr is used in ASCII Trie. (flutter/engine#18978) * b19a17d Implement an EGL resource context for the Linux shell. (flutter/engine#18918) * ca26b75 Make Linux shell plugin constructor descriptions consistent (flutter/engine#18940) * efd1452 Roll Skia from 9c401e7e1ace to f69e40841eb9 (11 revisions) (flutter/engine#18983) * e5845af Put JNI functions under an interface (flutter/engine#18903) * 1ddc6e1 Call destructor and fix check (flutter/engine#18985) * 7f71f1d Roll Fuchsia Mac SDK from oWhyp... to gAD3P... (flutter/engine#18982) * 74291b7 Roll Dart SDK from 0fab083e1c2b to e62b89c56d01 (10 revisions) (flutter/engine#18987) * 2739bbf [web] Provide a hook to disable location strategy (flutter/engine#18969) * 336d000 Roll Skia from f69e40841eb9 to 553496b66f12 (2 revisions) (flutter/engine#18992) * b82769b Roll Skia from 553496b66f12 to 0ad37b87549b (2 revisions) (flutter/engine#18993) * f5ca58b Roll Dart SDK from e62b89c56d01 to b0d2b97d2cd7 (4 revisions) (flutter/engine#18994) * 2a82a08 [dart] Account for compiler api change (flutter/engine#19002) * 369e0a9 Add ui_benchmarks (flutter/engine#18945) * a0a92d6 Roll Skia from 0ad37b87549b to de175abede4d (1 revision) (flutter/engine#18995) * cea5a9c Roll Dart SDK from b0d2b97d2cd7 to f043f9e5f6ea (6 revisions) (flutter/engine#18997) * d417772 Roll Fuchsia Mac SDK from gAD3P... to Wj0yo... (flutter/engine#19001) * 4538622 Roll Skia from de175abede4d to 32d5cfa1f35e (15 revisions) (flutter/engine#19005) * 71fce02 Fix shift-tab not working by adding more GTK->GLFW key mappings. (flutter/engine#18988) * 5ddc122 Fix inverted check in creating resource surface (flutter/engine#18989) * 87d8888 Show warning if method response errors occur and error not handled. (flutter/engine#18946) * 5171fbd Roll Skia from 32d5cfa1f35e to 21bbfc6c2dfe (5 revisions) (flutter/engine#19006) * 4bd6aea Always send key events, even if they're used for text input. (flutter/engine#18991) * 9f898e9 Don't process key events when the text input is not requested (flutter/engine#18990) * 48d7091 Roll buildroot for Windows warning update (flutter/engine#19000) * 5f37029 Roll Dart SDK from f043f9e5f6ea to f0ea02bc51f8 (22 revisions) (flutter/engine#19010) * ac809b4 onBeginFrame JNI (flutter/engine#18866) * e1c622b Make SKSL caching test work on Fuchsia on arm64 (flutter/engine#18572) * 2651beb Exit before pushing a trace event when layer tree holder is empty (flutter/engine#19008) * acf048b Remove log added for local testing (flutter/engine#19012) * 1f3aa23 Roll Dart SDK from f0ea02bc51f8 to 0b64f5488965 (9 revisions) (flutter/engine#19013) * 8dcc95d Roll Fuchsia Mac SDK from Wj0yo... to gR0Zc... (flutter/engine#19015) * f6455fa Roll Dart SDK from 0b64f5488965 to 50836c171e91 (4 revisions) (flutter/engine#19017) * b2fea9d Roll Skia from 21bbfc6c2dfe to 30212b7941d6 (6 revisions) (flutter/engine#19009) * 0065646 Roll Skia from 30212b7941d6 to 3d6bf04366f6 (17 revisions) (flutter/engine#19020) * 0a852d8 Revert "Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events (flutter#18979)" (flutter/engine#19023) * 194acdf apply null safety syntax to mobile dart:ui (flutter/engine#18933) * b0a0e0e Roll Skia from 3d6bf04366f6 to 637838d20abd (2 revisions) (flutter/engine#19021) * be499ab Roll Fuchsia Mac SDK from gR0Zc... to H-uAk... (flutter/engine#19022) * 8c24c41 Roll Skia from 637838d20abd to ac16760df463 (1 revision) (flutter/engine#19025) * 7cb7003 onEndFrame JNI (flutter/engine#18867) * e3fdb23 [fuchsia] Add ability to configure separate data and asset dirs (flutter/engine#18858) * 983b6e1 Call Shell::NotifyLowMemory when backgrounded/memory pressure occurs on Android (flutter/engine#19026) * f7d241f Wire up channel for restoration data (flutter/engine#18042) * e84d497 Fix hit testing logic in fuchsia a11y (flutter/engine#19029) * 801559a Revert to last-known-good-rev of Dart SDK (flutter/engine#19031)

onBeginFrame JNI

ba8dcb8

auto-assign bot requested a review from iskakaushik June 6, 2020 19:14

fluttergithubbot added the platform-android label Jun 6, 2020

googlebot added the cla: yes label Jun 6, 2020

cg021 requested review from blasten and removed request for iskakaushik June 6, 2020 19:14

Merge branch 'master' into jni_begin

8339329

cg021 force-pushed the jni_begin branch 2 times, most recently from 6a702da to 825c669 Compare June 10, 2020 01:52

sync with master

e37f96e

cg021 force-pushed the jni_begin branch from 439c7e7 to e37f96e Compare June 10, 2020 02:06

add onDisplayPlatformView for merging

3777b63

cg021 force-pushed the jni_begin branch from ecb1519 to 3777b63 Compare June 10, 2020 20:52

cg021 and others added 4 commits June 10, 2020 15:54

Merge branch 'master' into jni_begin

ea5b775

merge

6ad9de9

license error

07b0520

migrate to interface

de1467a

cg021 force-pushed the jni_begin branch from 86eefdf to de1467a Compare June 11, 2020 21:17

revert license

12f2df5

cg021 force-pushed the jni_begin branch 2 times, most recently from c0ab851 to 392ab99 Compare June 11, 2020 21:45

blasten reviewed Jun 11, 2020

View reviewed changes

cg021 force-pushed the jni_begin branch 3 times, most recently from 6c15415 to 44fed6d Compare June 11, 2020 22:11

license

127151e

cg021 force-pushed the jni_begin branch from 44fed6d to 127151e Compare June 11, 2020 22:14

Merge remote-tracking branch 'uptsream/master' into jni_begin

8720c2d

blasten approved these changes Jun 11, 2020

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

204b3ad

engine-flutter-autoroll mentioned this pull request Jun 16, 2020

Roll Engine from 965fbbed1776 to 3d4bb12ba783 (76 revisions) flutter/flutter#59596

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

e174beb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

4ff9485

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

123ea58

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

cae4913

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

642d0d1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

9887e46

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

fa6335a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

01cd54b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

a024cfe

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

96166f8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

030a3ea

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

c493e0a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

6fa0783

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

61a0550

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

9d2a8fa

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

c2d52ec

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

4411a75

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

fe5c504

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

00b66cb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

f685bf4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

fcf9df2

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

c4790d8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

4ab2312

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

47c93dd

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

ab49898

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

ac809b4 onBeginFrame JNI (flutter/engine#18866)

a3b86fd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onBeginFrame JNI #18866

onBeginFrame JNI #18866

cg021 commented Jun 6, 2020

blasten Jun 11, 2020

blasten Jun 11, 2020

blasten left a comment

onBeginFrame JNI #18866

onBeginFrame JNI #18866

Conversation

cg021 commented Jun 6, 2020

Description

Related Issues

Tests

Checklist

Breaking Change

blasten Jun 11, 2020

Choose a reason for hiding this comment

blasten Jun 11, 2020

Choose a reason for hiding this comment

blasten left a comment

Choose a reason for hiding this comment