Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events #18979

dnfield · 2020-06-10T22:19:42Z

Description

Right now, we only send the message to the framework and fail to notify the engine/dart that it should release resources if possible.

Related Issues

Fixes flutter/flutter#59182

Tests

I added the following tests:

Test that the FlutterEngine forwards the call to FlutterJNI
Test that the activity delegate calls the engine class under the right circumstances.

I updated the old embedding, but I'm not sure if that's tested.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.

xster

LGTM % comments. Thanks for fixing

xster · 2020-06-10T23:15:16Z

shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java

+   * This does not notify a Flutter application about memory pressure. For that,
+   * use the {@link SystemChannel#sendMemoryPressureWarning}.
+   */
+  public void notifyLowMemoryWarning() {


for modularity, put this in the DartExecutor since it's a dart specific thing

xster · 2020-06-10T23:17:11Z

shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java

@@ -316,6 +316,20 @@ public void removeEngineLifecycleListener(@NonNull EngineLifecycleListener liste
    engineLifecycleListeners.remove(listener);
  }

+  /**
+   * Notify the Dart VM that the system is experiencing memory pressure, and
+   * extra work should be taken to clean up internal resources and collect


Let's be more transparent here. Since this happens on backgrounding from onTrimMemory, let's not make the name and comment so ominous. Let's just say it's a good time to clean up.

I'd like to keep the name so that it's clearer. This is not API that people should call indiscriminately. And this way it's much easier to trace what it actually does on the C++ side.

xster · 2020-06-10T23:17:33Z

shell/platform/android/io/flutter/embedding/engine/FlutterJNI.java

@@ -823,6 +823,23 @@ public Bitmap getBitmap() {
  // TODO(mattcarroll): determine if this is nonull or nullable
  private native Bitmap nativeGetBitmap(long nativePlatformViewId);

+  /**
+   * Notifies the Dart VM of a low memory event, or that the application is in
+   * a state such that now is an appropriate time to free resources, such as


oh this is a better doc

Copied this to the other one :)

xster · 2020-06-10T23:19:05Z

...atform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

@@ -451,9 +451,16 @@ public void itSendsMessageOverSystemChannelWhenToldToTrimMemory() {
    delegate.onAttach(RuntimeEnvironment.application);


nit: you should change the test name now

xster · 2020-06-10T23:20:02Z

...atform/android/test/io/flutter/embedding/android/FlutterActivityAndFragmentDelegateTest.java

@@ -470,6 +477,7 @@ public void itSendsMessageOverSystemChannelWhenInformedOfLowMemory() {
    delegate.onLowMemory();


gaaclarke

lgtm

gaaclarke · 2020-06-11T00:06:44Z

shell/platform/android/test/io/flutter/embedding/engine/dart/DartExecutorTest.java

+
+    DartExecutor dartExecutor = new DartExecutor(mockFlutterJNI, mock(AssetManager.class));
+    dartExecutor.notifyLowMemoryWarning();
+    ;


fyi stray semicolon

…ory events (flutter/engine#18979)

…ory events (#18979)" This reverts commit f5ab179.

…ory events (#18979)" (#19023) This reverts commit f5ab179.

…ory events (flutter/engine#18979)

* 141ee78 Roll Dart SDK from 2b917f5b6a0e to 0fab083e1c2b (15 revisions) (flutter/engine#18974) * f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events (flutter/engine#18979) * 4dabac9 Roll Fuchsia Linux SDK from 8AiUM... to ThzHh... (flutter/engine#18976) * 50cae02 Reland: Add RAII wrapper for EGLSurface (flutter/engine#18977) * db7f226 Include the memory header as unique_ptr is used in ASCII Trie. (flutter/engine#18978) * b19a17d Implement an EGL resource context for the Linux shell. (flutter/engine#18918) * ca26b75 Make Linux shell plugin constructor descriptions consistent (flutter/engine#18940) * efd1452 Roll Skia from 9c401e7e1ace to f69e40841eb9 (11 revisions) (flutter/engine#18983) * e5845af Put JNI functions under an interface (flutter/engine#18903) * 1ddc6e1 Call destructor and fix check (flutter/engine#18985) * 7f71f1d Roll Fuchsia Mac SDK from oWhyp... to gAD3P... (flutter/engine#18982) * 74291b7 Roll Dart SDK from 0fab083e1c2b to e62b89c56d01 (10 revisions) (flutter/engine#18987) * 2739bbf [web] Provide a hook to disable location strategy (flutter/engine#18969) * 336d000 Roll Skia from f69e40841eb9 to 553496b66f12 (2 revisions) (flutter/engine#18992) * b82769b Roll Skia from 553496b66f12 to 0ad37b87549b (2 revisions) (flutter/engine#18993) * f5ca58b Roll Dart SDK from e62b89c56d01 to b0d2b97d2cd7 (4 revisions) (flutter/engine#18994) * 2a82a08 [dart] Account for compiler api change (flutter/engine#19002) * 369e0a9 Add ui_benchmarks (flutter/engine#18945) * a0a92d6 Roll Skia from 0ad37b87549b to de175abede4d (1 revision) (flutter/engine#18995) * cea5a9c Roll Dart SDK from b0d2b97d2cd7 to f043f9e5f6ea (6 revisions) (flutter/engine#18997) * d417772 Roll Fuchsia Mac SDK from gAD3P... to Wj0yo... (flutter/engine#19001) * 4538622 Roll Skia from de175abede4d to 32d5cfa1f35e (15 revisions) (flutter/engine#19005) * 71fce02 Fix shift-tab not working by adding more GTK->GLFW key mappings. (flutter/engine#18988) * 5ddc122 Fix inverted check in creating resource surface (flutter/engine#18989) * 87d8888 Show warning if method response errors occur and error not handled. (flutter/engine#18946) * 5171fbd Roll Skia from 32d5cfa1f35e to 21bbfc6c2dfe (5 revisions) (flutter/engine#19006) * 4bd6aea Always send key events, even if they're used for text input. (flutter/engine#18991) * 9f898e9 Don't process key events when the text input is not requested (flutter/engine#18990) * 48d7091 Roll buildroot for Windows warning update (flutter/engine#19000) * 5f37029 Roll Dart SDK from f043f9e5f6ea to f0ea02bc51f8 (22 revisions) (flutter/engine#19010) * ac809b4 onBeginFrame JNI (flutter/engine#18866) * e1c622b Make SKSL caching test work on Fuchsia on arm64 (flutter/engine#18572) * 2651beb Exit before pushing a trace event when layer tree holder is empty (flutter/engine#19008) * acf048b Remove log added for local testing (flutter/engine#19012) * 1f3aa23 Roll Dart SDK from f0ea02bc51f8 to 0b64f5488965 (9 revisions) (flutter/engine#19013) * 8dcc95d Roll Fuchsia Mac SDK from Wj0yo... to gR0Zc... (flutter/engine#19015) * f6455fa Roll Dart SDK from 0b64f5488965 to 50836c171e91 (4 revisions) (flutter/engine#19017) * b2fea9d Roll Skia from 21bbfc6c2dfe to 30212b7941d6 (6 revisions) (flutter/engine#19009) * 0065646 Roll Skia from 30212b7941d6 to 3d6bf04366f6 (17 revisions) (flutter/engine#19020) * 0a852d8 Revert "Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events (flutter#18979)" (flutter/engine#19023) * 194acdf apply null safety syntax to mobile dart:ui (flutter/engine#18933) * b0a0e0e Roll Skia from 3d6bf04366f6 to 637838d20abd (2 revisions) (flutter/engine#19021) * be499ab Roll Fuchsia Mac SDK from gR0Zc... to H-uAk... (flutter/engine#19022) * 8c24c41 Roll Skia from 637838d20abd to ac16760df463 (1 revision) (flutter/engine#19025) * 7cb7003 onEndFrame JNI (flutter/engine#18867) * e3fdb23 [fuchsia] Add ability to configure separate data and asset dirs (flutter/engine#18858) * 983b6e1 Call Shell::NotifyLowMemory when backgrounded/memory pressure occurs on Android (flutter/engine#19026) * f7d241f Wire up channel for restoration data (flutter/engine#18042) * e84d497 Fix hit testing logic in fuchsia a11y (flutter/engine#19029) * 801559a Revert to last-known-good-rev of Dart SDK (flutter/engine#19031)

dnfield added 2 commits June 9, 2020 20:46

fix build

48a1245

Dart_NotifyLowMemory on memory pressure in Android

5411470

dnfield requested a review from xster June 10, 2020 22:19

fluttergithubbot added the platform-android label Jun 10, 2020

auto-assign bot requested a review from gaaclarke June 10, 2020 22:19

fluttergithubbot added the platform-ios label Jun 10, 2020

googlebot added the cla: yes label Jun 10, 2020

Merge remote-tracking branch 'upstream/master' into android_mem

1a93d54

dnfield removed the platform-ios label Jun 10, 2020

xster reviewed Jun 10, 2020

View reviewed changes

review and format

5ad39c8

xster approved these changes Jun 10, 2020

View reviewed changes

gaaclarke approved these changes Jun 11, 2020

View reviewed changes

Update DartExecutorTest.java

8ade3ed

dnfield merged commit f5ab179 into flutter:master Jun 11, 2020

dnfield deleted the android_mem branch June 11, 2020 00:18

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

e636e49

…ory events (flutter/engine#18979)

engine-flutter-autoroll mentioned this pull request Jun 11, 2020

Roll Engine from 965fbbed1776 to b82769bdfb4b (15 revisions) flutter/flutter#59254

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

8aeb6e8

…ory events (flutter/engine#18979)

This was referenced Jun 11, 2020

Roll Engine from 965fbbed1776 to 2a82a0832901 (17 revisions) flutter/flutter#59278

Closed

Roll Engine from 965fbbed1776 to 369e0a9b9132 (18 revisions) flutter/flutter#59281

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

2287053

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

4d3376c

…ory events (flutter/engine#18979)

This was referenced Jun 11, 2020

Roll Engine from 965fbbed1776 to d417772d7acd (21 revisions) flutter/flutter#59282

Merged

Roll Engine from 965fbbed1776 to f6455fa6f26a (37 revisions) flutter/flutter#59345

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

7e8933e

…ory events (flutter/engine#18979)

blasten pushed a commit that referenced this pull request Jun 12, 2020

Revert "Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

799afc3

…ory events (#18979)" This reverts commit f5ab179.

blasten mentioned this pull request Jun 12, 2020

Revert "Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events" #19023

Merged

blasten pushed a commit that referenced this pull request Jun 12, 2020

Revert "Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

0a852d8

…ory events (#18979)" (#19023) This reverts commit f5ab179.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

a2b259f

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

f739598

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

b54cce5

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

e84da8a

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

f810a00

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

a34892a

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

bd3ceae

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

d89bfa9

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

3a3f8aa

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

9f10b6c

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

4baa55a

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

481b379

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

03bfbcf

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

e5892c6

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

cd13b13

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

d9b578c

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

5eae8bc

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

318c7c4

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

7ac4de0

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

bf0b179

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

e92c9d0

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

6b50bd7

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 17, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

2094f89

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

1595eb8

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

cbb7e39

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

ccdd362

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

545ef75

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

9fdc6d2

…ory events (flutter/engine#18979)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020

f5ab179 Call Shell::NotifyLowMemoryWarning on Android Trim and LowMem…

255c067

…ory events (flutter/engine#18979)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events #18979

Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events #18979

dnfield commented Jun 10, 2020

xster left a comment

xster Jun 10, 2020

dnfield Jun 10, 2020

xster Jun 10, 2020

dnfield Jun 10, 2020

xster Jun 10, 2020

dnfield Jun 10, 2020

xster Jun 10, 2020

dnfield Jun 10, 2020

xster Jun 10, 2020

dnfield Jun 10, 2020

gaaclarke left a comment

gaaclarke Jun 11, 2020

		@@ -451,9 +451,16 @@ public void itSendsMessageOverSystemChannelWhenToldToTrimMemory() {
		delegate.onAttach(RuntimeEnvironment.application);

		@@ -470,6 +477,7 @@ public void itSendsMessageOverSystemChannelWhenInformedOfLowMemory() {
		delegate.onLowMemory();

Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events #18979

Call Shell::NotifyLowMemoryWarning on Android Trim and LowMemory events #18979

Conversation

dnfield commented Jun 10, 2020

Description

Related Issues

Tests

Breaking Change

xster left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaaclarke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment