hasStrings Linux #21388
hasStrings Linux #21388
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| FlMethodCall* method_call) { | ||
| GtkClipboard* clipboard = | ||
| gtk_clipboard_get_default(gdk_display_get_default()); | ||
| gtk_clipboard_request_text(clipboard, clipboard_text_has_strings_cb, |
There was a problem hiding this comment.
@robert-ancell Is there a reason to use the *_request_* APIs over the *_wait_* APIs? Otherwise this could all just be a call to gtk_clipboard_wait_is_text_available ()
There was a problem hiding this comment.
I'm merging this PR, but feel free to reply if anyone thinks this doesn't seem right and I'm happy to take a look at changing this.
There was a problem hiding this comment.
The *_wait_* methods would block and cause no other Flutter method calls etc to be handled. So the implemented method is correct.
There was a problem hiding this comment.
Ah good to know, thanks for following up @robert-ancell !
flutter/engine@7e6191d...9a7b556 2020-10-06 [email protected] hasStrings Linux (flutter/engine#21388) 2020-10-06 [email protected] add api_conform_test to analyze step. remove build script. (flutter/engine#21633) 2020-10-06 [email protected] Roll Fuchsia Mac SDK from 8q-OCkyhO... to xM2vYLfIT... (flutter/engine#21635) 2020-10-06 [email protected] Roll Skia from 33b42e12ab71 to 107114dd1d6e (5 revisions) (flutter/engine#21634) 2020-10-06 [email protected] Roll Fuchsia Linux SDK from HeAkKHbFY... to kr1tNtZvZ... (flutter/engine#21630) 2020-10-06 [email protected] running web tests only on DEPS and web directories (flutter/engine#21613) 2020-10-06 [email protected] Roll Skia from c3bdd1c597dc to 33b42e12ab71 (6 revisions) (flutter/engine#21628) 2020-10-06 [email protected] Use the gpu config for shell_unittests to declare SHELL_ENABLE_{GL,VULKAN} (flutter/engine#21603) 2020-10-06 [email protected] [linux] Allow engine flags via environment vars (flutter/engine#21497)
hasStrings method for clipboard status, Linux
Description
Implements the hasStrings method for the Linux platform.
Related Issues
Main issue: flutter/flutter#60145
hasStrings iOS: #19859
hasStrings Android: #20393
hasStrings Mac: #20531
hasStrings framework: flutter/flutter#61774
Tests
I added no tests. Please let me know what the requirements are for testing on Linux if this does in fact need tests!