This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[linux] Allow engine flags via environment vars #21497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnfield Ping? |
|
luci-engine bot seems to be confused about status; the last row is entirely green. Given that, landing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 6, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Oct 7, 2020
flutter/engine@7e6191d...9a7b556 2020-10-06 [email protected] hasStrings Linux (flutter/engine#21388) 2020-10-06 [email protected] add api_conform_test to analyze step. remove build script. (flutter/engine#21633) 2020-10-06 [email protected] Roll Fuchsia Mac SDK from 8q-OCkyhO... to xM2vYLfIT... (flutter/engine#21635) 2020-10-06 [email protected] Roll Skia from 33b42e12ab71 to 107114dd1d6e (5 revisions) (flutter/engine#21634) 2020-10-06 [email protected] Roll Fuchsia Linux SDK from HeAkKHbFY... to kr1tNtZvZ... (flutter/engine#21630) 2020-10-06 [email protected] running web tests only on DEPS and web directories (flutter/engine#21613) 2020-10-06 [email protected] Roll Skia from c3bdd1c597dc to 33b42e12ab71 (6 revisions) (flutter/engine#21628) 2020-10-06 [email protected] Use the gpu config for shell_unittests to declare SHELL_ENABLE_{GL,VULKAN} (flutter/engine#21603) 2020-10-06 [email protected] [linux] Allow engine flags via environment vars (flutter/engine#21497)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Oct 20, 2020
Adds the ability to pass engine switches temporarily at runtime via environment variables. Uses the same approach recently added to Windows and macOS. This is enabled only for debug/profile to avoid potential issues with tampering with released applications, but if there is a need for that in the future it could be added (potentially with a whitelist, as is currently used for Dart VM flags). Fixes flutter/flutter#60393
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to pass engine switches temporarily at runtime via
environment variables. Uses the same approach recently added to
Windows and macOS.
This is enabled only for debug/profile to avoid potential issues with
tampering with released applications, but if there is a need for that in
the future it could be added (potentially with a whitelist, as is
currently used for Dart VM flags).
Related Issues
Fixes flutter/flutter#60393
Tests
I added the following tests: FlDartProject tests that the switches are passed through correctly.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.