This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Handle multiple views in platformViews path #25343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
c162604 to
6dd1830
Compare
|
I'm on PTO through monday, I can look at this on Tuesday if you want but probably not before that |
jaeheon
reviewed
Apr 3, 2021
jaeheon
reviewed
Apr 3, 2021
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.h
Outdated
Show resolved
Hide resolved
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
6dd1830 to
307820f
Compare
jaeheon
reviewed
Apr 7, 2021
jaeheon
reviewed
Apr 7, 2021
shell/platform/fuchsia/flutter/fuchsia_external_view_embedder.cc
Outdated
Show resolved
Hide resolved
freiling
approved these changes
Apr 8, 2021
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
307820f to
514d9a3
Compare
|
@arbreng The test failure looks related. |
Yes, I have some cleanup yet to do on this CL before landing it. It will be this evening or tomorrow That includes breaking up this monster CL into a few distinct commits at least |
arbreng
force-pushed
the
fuchsia-views-threading
branch
3 times, most recently
from
f9d732a to
4ee84df
Compare
arbreng
force-pushed
the
fuchsia-views-threading
branch
from
4ee84df to
00c3f17
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new platformViews path we are introducing for Fuchsia is not able to handle multiple platform views at once. This PR fixes that and enables proper view IDs with platform_view channel events.
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=71337