This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Fix bad syntax in viewStateConnected msg #25853
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The platform message for viewStateChanged has a JSON syntax error, introduced in #25343.
The dart code therefore can't parse this message and just reports an error. This causes a lot of annoying logspam and means the viewStateChanged event doesn't work properly.
Follow-on fix for: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=71337