This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove obsolete instructions from scenario_app readme, pass depfile correctly. #28732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
approved these changes
Sep 20, 2021
| ``` | ||
|
|
||
| in your shell. |
There was a problem hiding this comment.
While you are here, do you mind adding a little instruction for running locally through xcode?
Something like:
To run or debug in XCode, open the proj file located in <path_to_engine>/src/out/ios_debug_sim_unopt/scenario_app/Scenarios/Scenarios.xcodeproj, and run all tests with cmd+u or use XCode UI to run selected tests.
dnfield
added
the
waiting for tree to go green
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
|
Dan is going to rebase on ToT. The ci.yaml validation failure is unrelated and is probably resolved. |
dnfield
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 23, 2021
…epfile correctly. (flutter/engine#28732)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2021
…epfile correctly. (flutter/engine#28732)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#90303 by removing out of date instructions. @blasten, I filed flutter/flutter#90401 but please feel free to dedupe if there is an existing issue for that already.
Fixes flutter/flutter#88179 by shifting the location of the
--depfileargument to be to the frontend server instead of to the VM. This does have the drawback that it will fail to recompile properly if the frontend server sources are modified, but unfortunately I can't see a way to get a single combined depfile for all the sources.