-
Notifications
You must be signed in to change notification settings - Fork 28.5k
scenario_app build rules doesn't recompile when files are edited #88179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is jit mode. App.framework is a stub in that case. You should get an error during kernel complication though |
Ahh okay, the problem is made worse because the App.framework is used in UI tests which makes it hard to debug problems in the underlying process. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
shoot, got so caught up with the other issue I mentioned I forgot that it was off topic from the original issue of not having compilation errors show up. |
I suspect the files aren't even getting compiled. Not only am I not getting compilation errors, I'm also seeing the old behavior in spite of changes. |
If you touch |
Sounds like a depfile issue. At one point I listed all the sources explicitly but then I thought the depfile would work. @zanderso maybe knows |
So the depfile we're getting from Dart does not contain the application sources. I'm trying to get feedback fromt he Dart team about whether this is WAI or not. If it is we need to list the sources manually, which seems unfortunate. |
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Steps to reproduce:
flutter/testing/scenario_app/lib/src/scenarios.dart
out/ios_debug_sim_unopt/scenario_app/Scenarios/App.framework
autoninja -C out/ios_debug_sim_unopt && autoninja -C out/host_debug_unopt/
out/ios_debug_sim_unopt/scenario_app/Scenarios/App.framework
has been regenerated somehow despite the errorcc @dnfield
The text was updated successfully, but these errors were encountered: