Skip to content

scenario_app build rules doesn't recompile when files are edited #88179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaaclarke opened this issue Aug 13, 2021 · 16 comments · Fixed by flutter/engine#28732
Closed

scenario_app build rules doesn't recompile when files are edited #88179

gaaclarke opened this issue Aug 13, 2021 · 16 comments · Fixed by flutter/engine#28732
Assignees
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-ios iOS applications specifically

Comments

@gaaclarke
Copy link
Member

gaaclarke commented Aug 13, 2021

Steps to reproduce:

  1. Type garbage into the file at flutter/testing/scenario_app/lib/src/scenarios.dart
  2. delete out/ios_debug_sim_unopt/scenario_app/Scenarios/App.framework
  3. compile with autoninja -C out/ios_debug_sim_unopt && autoninja -C out/host_debug_unopt/
  4. Notice that there was no compilation error
  5. Notice that out/ios_debug_sim_unopt/scenario_app/Scenarios/App.framework has been regenerated somehow despite the error

cc @dnfield

@gaaclarke gaaclarke added the engine flutter/engine repository. See also e: labels. label Aug 13, 2021
@dnfield
Copy link
Contributor

dnfield commented Aug 13, 2021

This is jit mode. App.framework is a stub in that case. You should get an error during kernel complication though

@gaaclarke
Copy link
Member Author

Ahh okay, the problem is made worse because the App.framework is used in UI tests which makes it hard to debug problems in the underlying process.

@gaaclarke gaaclarke changed the title scenario_app build rules don't appear to work scenario_app build rules don't surface compilation errors Aug 13, 2021
@gaaclarke

This comment has been minimized.

@dnfield

This comment has been minimized.

@dnfield

This comment has been minimized.

@gaaclarke

This comment has been minimized.

@dnfield

This comment has been minimized.

@dnfield

This comment has been minimized.

@gaaclarke

This comment has been minimized.

@gaaclarke

This comment has been minimized.

@gaaclarke
Copy link
Member Author

shoot, got so caught up with the other issue I mentioned I forgot that it was off topic from the original issue of not having compilation errors show up.

@gaaclarke gaaclarke reopened this Aug 13, 2021
@gaaclarke
Copy link
Member Author

I suspect the files aren't even getting compiled. Not only am I not getting compilation errors, I'm also seeing the old behavior in spite of changes.

@gaaclarke
Copy link
Member Author

If you touch testing/scenario_app/lib/main.dart it seems to cause a recompilation, touching testing/scenario_app/lib/src/scenarios.dart isn't enough.

@gaaclarke gaaclarke changed the title scenario_app build rules don't surface compilation errors scenario_app build rules doesn't recompile when files are edited Aug 13, 2021
@dnfield
Copy link
Contributor

dnfield commented Aug 13, 2021

Sounds like a depfile issue. At one point I listed all the sources explicitly but then I thought the depfile would work. @zanderso maybe knows

@chinmaygarde chinmaygarde added the P2 Important issues not at the top of the work list label Aug 16, 2021
@cyanglaz cyanglaz added platform-ios iOS applications specifically c: tech-debt Technical debt, code quality, testing, etc. labels Sep 7, 2021
@dnfield
Copy link
Contributor

dnfield commented Sep 20, 2021

So the depfile we're getting from Dart does not contain the application sources. I'm trying to get feedback fromt he Dart team about whether this is WAI or not. If it is we need to list the sources manually, which seems unfortunate.

@dnfield dnfield self-assigned this Sep 20, 2021
@dnfield dnfield added P1 High-priority issues at the top of the work list and removed P2 Important issues not at the top of the work list labels Sep 20, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-ios iOS applications specifically
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants