Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add 'explicit' to header files #29741

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

zanderso
Copy link
Member

This PR adds explicit to constructor declarations that are asked for in a host_debug build on Linux using the following .clang-tidy file:

Checks: '-*,google-explicit-constructor'
WarningsAsErrors: '-*,google-explicit-constructor'
HeaderFilterRegex: '.*/flutter/.*h$'

For flutter/flutter#93576

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android labels Nov 14, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 17:35
@flutter-dashboard flutter-dashboard bot changed the base branch from main to master November 15, 2021 17:35
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to main. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@zanderso
Copy link
Member Author

@CaseyHillers why is this PR still blocked?

@CaseyHillers
Copy link
Contributor

@zanderso there's a tree failure now. The status is reporting correctly.

@zanderso
Copy link
Member Author

zanderso commented Nov 16, 2021

@CaseyHillers GitHub is telling me that merging is blocked. I should be able to land an lgtm'd PR even when the tree is red. (This one doesn't need to, but I should be able to.)

In particular it says "The base branch restricts merging to authorized users."

@jmagman
Copy link
Member

jmagman commented Nov 16, 2021

@CaseyHillers changed the base to main, but it still says the base is master...?

@jmagman jmagman changed the base branch from master to main November 16, 2021 02:13
@jmagman
Copy link
Member

jmagman commented Nov 16, 2021

@CaseyHillers changed the base to main, but it still says the base is master...?

Switching back to main unblocked it again. Not sure how it got back to being based on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants