-
Notifications
You must be signed in to change notification settings - Fork 6k
Add 'explicit' to darwin embedder constructors #29827
Conversation
9b6b41b
to
befd4e1
Compare
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@@ -23,8 +23,10 @@ struct TextEditingDelta { | |||
TextRange range, | |||
const std::string& text); | |||
|
|||
// NOLINTNEXTLINE(google-explicit-constructor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how painful it would be, but I think these two are cases where we would want to have explicit
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked, in this case I was confused about which one was erroring.
fml/platform/darwin/cf_utils.h
Outdated
// NOLINTNEXTLINE(google-explicit-constructor) | ||
operator bool() const { return instance_ != nullptr; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be explicit
I think.
luci-engine status is wrong, infra is investigating. Tree is actually green, merging. |
Add
explicit
to constructor declarations in macOShost_debug
andios_debug
Include headers using header filter regex:
https://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html
macOS and iOS version of #29741
For flutter/flutter#93576