Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Remove the --passfail flag when calling goldctl in post-submit #32071

Merged
merged 2 commits into from
Mar 16, 2022
Merged

[web] Remove the --passfail flag when calling goldctl in post-submit #32071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f6a546
[web] Remove the --passfail flag when calling goldctl in post-submit
mdebbar Mar 16, 2022
2f1a8cc
add comment
mdebbar Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion web_sdk/web_test_utils/lib/skia_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ class SkiaGoldClient {
'--commit', commitHash,
'--keys-file', keys.path,
'--failure-file', failures.path,
'--passfail',
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 225, you may want to add a comment explaining the one remaining --passfail and why that is ok for tryjobs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for taking a look!


if (imgtestInitCommand.contains(null)) {
Expand Down Expand Up @@ -223,6 +222,9 @@ class SkiaGoldClient {
'--commit', commitHash,
'--keys-file', keys.path,
'--failure-file', failures.path,
// This is running in pre-submit so it's okay for the `goldctl` commands
// to fail when the images don't match. But during post-submit
// (in `_imgtestInit`) we shouldn't let the command fail.
'--passfail',
'--crs', 'github',
'--patchset_id', commitHash,
Expand Down