[web] Remove the --passfail flag when calling goldctl in post-submit #32071
Conversation
| @@ -132,7 +132,6 @@ class SkiaGoldClient { | |||
| '--commit', commitHash, | |||
| '--keys-file', keys.path, | |||
| '--failure-file', failures.path, | |||
| '--passfail', | |||
| ]; | |||
There was a problem hiding this comment.
On line 225, you may want to add a comment explaining the one remaining --passfail and why that is ok for tryjobs
There was a problem hiding this comment.
Done. Thanks for taking a look!
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
|
Gold has detected about 18 new digest(s) on patchset 2. |
mdebbar
added
the
waiting for tree to go green
* 09d7bcc Optionally specify the target dir in tools/gn (flutter/engine#32065) * a00ba24 Fix done button click not blur in iOS keyboard (flutter/engine#31718) * 81547d1 Add a display list op to clear to transformation stack. (flutter/engine#32050) * 2309bcc Add WASM target in gn (flutter/engine#31670) * 852e800 [web] Remove the --passfail flag when calling goldctl in post-submit (flutter/engine#32071) * eb1c50d Fix issues with nested gradients in html renderer. (flutter/engine#31887) * fb0fd74 Update the magic number for JPEG to just FF D8 FF. (flutter/engine#32076) * 233c17c Wrap the global timeline event handler callback in a std::atomic (flutter/engine#32073) * dfde2aa Roll Dart SDK from 24bf86f16411 to 5bc905e69609 (9 revisions) (flutter/engine#32075)
After talking to @kjlubick, he pointed out that the
--passfailflag causesgoldctlto perform the image comparison and fail sometimes in post-submit.