Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update the magic number for JPEG to just FF D8 FF. #32076

Merged

Conversation

harryterkelsen
Copy link
Contributor

This matches what Wikipedia says: https://en.wikipedia.org/wiki/JPEG

Fixes flutter/flutter#100055

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen harryterkelsen requested a review from yjbanov March 16, 2022 22:13
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 16, 2022
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skia-gold
Copy link

Gold has detected about 18 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/32076

@harryterkelsen harryterkelsen merged commit fb0fd74 into flutter:main Mar 16, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2022
zanderso pushed a commit to flutter/flutter that referenced this pull request Mar 17, 2022
* 09d7bcc Optionally specify the target dir in tools/gn (flutter/engine#32065)

* a00ba24 Fix done button click not blur in iOS keyboard (flutter/engine#31718)

* 81547d1 Add a display list op to clear to transformation stack. (flutter/engine#32050)

* 2309bcc Add WASM target in gn (flutter/engine#31670)

* 852e800 [web] Remove the --passfail flag when calling goldctl in post-submit (flutter/engine#32071)

* eb1c50d Fix issues with nested gradients in html renderer. (flutter/engine#31887)

* fb0fd74 Update the magic number for JPEG to just FF D8 FF. (flutter/engine#32076)

* 233c17c Wrap the global timeline event handler callback in a std::atomic (flutter/engine#32073)

* dfde2aa Roll Dart SDK from 24bf86f16411 to 5bc905e69609 (9 revisions) (flutter/engine#32075)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Web Canvaskit] ImageCodecException for certain JPEG files
3 participants