Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux][A11y] report disabled animations and high contrast accessibility features #33313

Merged
merged 5 commits into from
Jun 26, 2022
Merged

[Linux][A11y] report disabled animations and high contrast accessibility features #33313

merged 5 commits into from
Jun 26, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented May 13, 2022 

MaterialApp(
  highContrastTheme: ThemeData.from(
    colorScheme: const ColorScheme.highContrastLight(),
  ),
)
a11y.mp4

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jpnurmi jpnurmi mentioned this pull request May 13, 2022
Closed
robert-ancell
robert-ancell reviewed Jun 16, 2022
View reviewed changes
robert-ancell
robert-ancell approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member

Can we land this? Seems like everything is green!

@robert-ancell robert-ancell merged commit 00b7292 into flutter:main Jun 26, 2022
jpnurmi added a commit to jpnurmi/engine that referenced this pull request Jun 27, 2022
@jpnurmi
Fix build on Linux
1ade552 
The MockBinaryMessenger tweaks applied by flutter#33955 made the newly added
tests in flutter#33313 not build.
jpnurmi added a commit to jpnurmi/engine that referenced this pull request Jun 27, 2022
@jpnurmi
Fix build on Linux
ed815ac 
The MockBinaryMessenger tweaks applied by flutter#33955 caused the newly added
tests in flutter#33313 to not build.
@jpnurmi jpnurmi mentioned this pull request Jun 27, 2022
Merged
zanderso added a commit that referenced this pull request Jun 27, 2022
@zanderso
Revert "[Linux][A11y] report disabled animations and high contrast ac…
36aef43 
…cessibility features (#33313)"

This reverts commit 00b7292.
@zanderso zanderso mentioned this pull request Jun 27, 2022
Closed
zanderso pushed a commit that referenced this pull request Jun 27, 2022
@jpnurmi
Fix build on Linux (#34312)
1aefda0 
* Fix build on Linux

The MockBinaryMessenger tweaks applied by #33955 caused the newly added
tests in #33313 to not build.

* Fix clang-tidy failures
@jpnurmi jpnurmi deleted the a11y-features branch June 27, 2022 15:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2022
@engine-flutter-autoroll
00b7292 [Linux][A11y] report disabled animations and high contrast ac…
4b42134 
…cessibility features (flutter/engine#33313)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robert-ancell robert-ancell robert-ancell approved these changes

Assignees
No one assigned
Labels
platform-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpnurmi @chinmaygarde @robert-ancell