This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Linux][A11y] implement AtkEditableText interface #33955
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows introducing specialized subclasses that implement such a11y interfaces as AtkEditableText that should not be implemented for the generic node.
Prepare API required for the upcoming AtkEditableText implementation.
This changes the a11y node creation flow so that (unknown) child nodes are not pre-created when their parent is updated but "pending" child node IDs are collected for later. Parent-child relationships are established at the end of update batches when all nodes have been created.
-1 is only supported since glib 2.72
robert-ancell
suggested changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the above LGTM
robert-ancell
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From Triage: Is this blocked? May I commit this? |
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Jun 27, 2022
The MockBinaryMessenger tweaks applied by flutter#33955 made the newly added tests in flutter#33313 not build.
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Jun 27, 2022
The MockBinaryMessenger tweaks applied by flutter#33955 caused the newly added tests in flutter#33313 to not build.
Merged
zanderso
pushed a commit
that referenced
this pull request
Jun 27, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the AtkEditableText interface to add full accessibility support for Flutter text fields on Linux.
Solves: flutter/flutter#103191
Pre-launch Checklist
///
).flutter-a11y-editable-text.mp4