Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux][A11y] implement AtkEditableText interface #33955

Merged
merged 7 commits into from
Jun 26, 2022

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jun 10, 2022

This PR implements the AtkEditableText interface to add full accessibility support for Flutter text fields on Linux.

Solves: flutter/flutter#103191

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
flutter-a11y-editable-text.mp4

jpnurmi added 4 commits June 10, 2022 11:01
This allows introducing specialized subclasses that implement such a11y
interfaces as AtkEditableText that should not be implemented for the
generic node.
Prepare API required for the upcoming AtkEditableText implementation.
This changes the a11y node creation flow so that (unknown) child nodes
are not pre-created when their parent is updated but "pending" child
node IDs are collected for later. Parent-child relationships are
established at the end of update batches when all nodes have been
created.
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above LGTM

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde
Copy link
Member

From Triage: Is this blocked? May I commit this?

@robert-ancell robert-ancell merged commit 5ca80bd into flutter:main Jun 26, 2022
jpnurmi added a commit to jpnurmi/engine that referenced this pull request Jun 27, 2022
The MockBinaryMessenger tweaks applied by flutter#33955 made the newly added
tests in flutter#33313 not build.
jpnurmi added a commit to jpnurmi/engine that referenced this pull request Jun 27, 2022
The MockBinaryMessenger tweaks applied by flutter#33955 caused the newly added
tests in flutter#33313 to not build.
@jpnurmi jpnurmi mentioned this pull request Jun 27, 2022
zanderso added a commit that referenced this pull request Jun 27, 2022
zanderso pushed a commit that referenced this pull request Jun 27, 2022
* Fix build on Linux

The MockBinaryMessenger tweaks applied by #33955 caused the newly added
tests in #33313 to not build.

* Fix clang-tidy failures
@jpnurmi jpnurmi deleted the a11y-text branch June 27, 2022 15:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants