Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Stop sending text to framework #33892

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Stop sending text to framework #33892

merged 1 commit into from
Jun 9, 2022

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Jun 8, 2022 •
edited
Loading

Part of Issue #34688 for Android.

Stops Android engine from sending text to the framework. See this comment for context.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@camsim99 camsim99 requested a review from justinmc June 8, 2022 16:43
justinmc
justinmc approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@camsim99 camsim99 added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 9, 2022
@fluttergithubbot fluttergithubbot merged commit 64c743b into flutter:main Jun 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
64c743b Stop sending text to framework (flutter/engine#33892)
9719b84
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@camsim99 @houhuayong
Stop sending text to framework (flutter#33892)
e61ac5a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camsim99 @justinmc @fluttergithubbot