This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Fuchsia] Support scroll_*_physical_pixel fields #34325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chaopeng
changed the title
|
@dkwingsmt @moffatman PTAL thank you. |
moffatman
reviewed
Jul 13, 2022
moffatman
reviewed
Jul 13, 2022
moffatman
reviewed
Jul 15, 2022
moffatman
reviewed
Jul 15, 2022
moffatman
reviewed
Jul 15, 2022
moffatman
reviewed
Jul 15, 2022
moffatman
reviewed
Jul 15, 2022
dkwingsmt
reviewed
Jul 15, 2022
dkwingsmt
approved these changes
Jul 15, 2022
Co-authored-by: Tong Mu <[email protected]>
Co-authored-by: Callum Moffat <[email protected]>
akbiggs
approved these changes
Jul 15, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
* [WIP][Fuchsia] Support scroll_physical_pixel fields * add test * update * update * update * update * update * update * update * update * use scroll_delta instead of pan * use kMouse * use kMouse * Update shell/platform/fuchsia/flutter/pointer_delegate.cc Co-authored-by: Tong Mu <[email protected]> * Update shell/platform/fuchsia/flutter/pointer_delegate.cc Co-authored-by: Callum Moffat <[email protected]> * format Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Callum Moffat <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 16, 2022
* 92606c2 [fuchsia][scenic] Reland Move pointer injector to embedder. (flutter/engine#34692) * 0627351 [Fuchsia] Support scroll_*_physical_pixel fields (flutter/engine#34325) * 9300363 Roll Skia from 7d1636010a55 to 2cf696124c82 (2 revisions) (flutter/engine#34696) * 59e1595 Roll Skia from 2cf696124c82 to 849628568612 (1 revision) (flutter/engine#34697) * 92b371f Roll Skia from 849628568612 to ed71b72e0213 (1 revision) (flutter/engine#34703) * 4991402 Roll Dart SDK from 92c7843b2ece to 54cc31cd98db (1 revision) (flutter/engine#34704) * e0944a3 Roll Dart SDK from 54cc31cd98db to 1b845f6a8c90 (1 revision) (flutter/engine#34705)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…7784) * 92606c2 [fuchsia][scenic] Reland Move pointer injector to embedder. (flutter/engine#34692) * 0627351 [Fuchsia] Support scroll_*_physical_pixel fields (flutter/engine#34325) * 9300363 Roll Skia from 7d1636010a55 to 2cf696124c82 (2 revisions) (flutter/engine#34696) * 59e1595 Roll Skia from 2cf696124c82 to 849628568612 (1 revision) (flutter/engine#34697) * 92b371f Roll Skia from 849628568612 to ed71b72e0213 (1 revision) (flutter/engine#34703) * 4991402 Roll Dart SDK from 92c7843b2ece to 54cc31cd98db (1 revision) (flutter/engine#34704) * e0944a3 Roll Dart SDK from 54cc31cd98db to 1b845f6a8c90 (1 revision) (flutter/engine#34705)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia has landed precision scroll related field at https://fuchsia-review.googlesource.com/c/fuchsia/+/673071/2/sdk/fidl/fuchsia.ui.pointer/mouse.fidl
We support scroll_*_physical_pixel fields in this PR.
Fixes: flutter/flutter#106670
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.