This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia][scenic] Reland Move pointer injector to embedder. #34692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
reviewed
Jul 15, 2022
arbreng
approved these changes
Jul 15, 2022
shivesh-ganju
force-pushed
the
new_flutter_view_lib
branch
2 times, most recently
from
6bb4efa to
c2d979e
Compare
This PR moves the pointer injector library from fuchsia views library present in fuchsia.git to the flutter embedder. Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
shivesh-ganju
force-pushed
the
new_flutter_view_lib
branch
from
c2d979e to
54212e8
Compare
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
…34692) This PR moves the pointer injector library from fuchsia views library present in fuchsia.git to the flutter embedder. Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 16, 2022
* 92606c2 [fuchsia][scenic] Reland Move pointer injector to embedder. (flutter/engine#34692) * 0627351 [Fuchsia] Support scroll_*_physical_pixel fields (flutter/engine#34325) * 9300363 Roll Skia from 7d1636010a55 to 2cf696124c82 (2 revisions) (flutter/engine#34696) * 59e1595 Roll Skia from 2cf696124c82 to 849628568612 (1 revision) (flutter/engine#34697) * 92b371f Roll Skia from 849628568612 to ed71b72e0213 (1 revision) (flutter/engine#34703) * 4991402 Roll Dart SDK from 92c7843b2ece to 54cc31cd98db (1 revision) (flutter/engine#34704) * e0944a3 Roll Dart SDK from 54cc31cd98db to 1b845f6a8c90 (1 revision) (flutter/engine#34705)
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
…7784) * 92606c2 [fuchsia][scenic] Reland Move pointer injector to embedder. (flutter/engine#34692) * 0627351 [Fuchsia] Support scroll_*_physical_pixel fields (flutter/engine#34325) * 9300363 Roll Skia from 7d1636010a55 to 2cf696124c82 (2 revisions) (flutter/engine#34696) * 59e1595 Roll Skia from 2cf696124c82 to 849628568612 (1 revision) (flutter/engine#34697) * 92b371f Roll Skia from 849628568612 to ed71b72e0213 (1 revision) (flutter/engine#34703) * 4991402 Roll Dart SDK from 92c7843b2ece to 54cc31cd98db (1 revision) (flutter/engine#34704) * e0944a3 Roll Dart SDK from 54cc31cd98db to 1b845f6a8c90 (1 revision) (flutter/engine#34705)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the pointer injector library from fuchsia views library
present in fuchsia.git to the flutter embedder.
Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
Manual Verification
Successfully opened and closed terminal
Successfully opened and closed Spinning square
Successfully opened and closed Chrome