This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Avoid segfault when converting no-op ColorFilter to ImageFilter #37596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Nov 14, 2022
dnfield
added
the
autosubmit
|
Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2022
…115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (#37336)" (flutter/engine#37609)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing the
DlColorFilterImageFilter, it doesn't tolerate nullptr. But if Skia decides the color filter is a no-op, we're giving it nullptr.It might be useful to have something in DL to signify no-op, or otherwise optimize these away, but it's probably a micro-optimization if anything and we should at least avoid crashing.
fixes flutter/flutter#115143