Archive windows gen_snapshot.exe. #35414

godofredoc · 2022-08-15T21:08:04Z

This is required to enable engine_v2 recipes for windows platform.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

zanderso · 2022-08-17T17:07:44Z

common/config.gni

@@ -22,6 +22,9 @@ declare_args() {

  # Whether to use a prebuilt Dart SDK instead of building one.
  flutter_prebuilt_dart_sdk = false
+
+  # The android cpu used to generate windows artifacts.
+  android_cpu = "arm"


This doesn't seem quite right. I need some time to investigate.

It seems like this workaround would be a continuation of this hack:

engine/tools/gn

Line 289 in 4b32f2e

# No cross-compilation on Windows (for now). Use host toolchain that

Instead of going further in this direction, we should try to remove the hack. (Added/expanded on here #3883 cc @rmacnak-google)

Following #37125, I think android_cpu is no longer needed, and target_cpu can be used. But I haven't actually tried it myself ;-)

loic-sharma · 2022-11-07T18:29:41Z

build/archives/BUILD.gn

+if (is_win) {
+  zip_bundle("archive_win_gen_snapshot") {
+    deps = [ "//third_party/dart/runtime/bin:gen_snapshot" ]
+    output = "$target_platform_name-$android_cpu-$flutter_runtime_mode/windows-x64.zip"


@pbo-linaro is working on adding Arm64 support to Windows (see flutter/flutter#62597 and #35962). Do we need to anything for arm64 artifacts here?

dart-sdk for windows-arm64 is building fine (previous work before flutter), so that could be nice to prepare this part in this PR if possible.

This is also covering windows arm64.

This is required to enable engine_v2 recipes for windows platform. Bug: flutter/flutter#81855

godofredoc · 2022-11-14T15:58:05Z

@zanderso this is complete and ready for review.

build/archives/BUILD.gn

Co-authored-by: Zachary Anderson <[email protected]>

godofredoc · 2022-11-14T18:20:04Z

Validated that new changes are working correctly end to end: https://chromium-swarm.appspot.com/task?id=5e9019bbf8ad6310

zanderso

LGTM!

…115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (#37336)" (flutter/engine#37609)

* Archive windows gen_snapshot.exe. This is required to enable engine_v2 recipes for windows platform. Bug: flutter/flutter#81855 * Add dep to generate gen_snapshot.exe. * Use target platform name rather than host. * Use prebuilt_arch. * Use platform_name instead of is_win. * Remove android check. * Fix output name. * Separate platform and cpu in name. * Remove failing line. * Use dart_target_arch rather than target_cpu in windows. * Add dart_target_arch to scope. * Add support for android_cpu. * Fix android_cpu variable name. * Rebase to ToT * Try to use target cpu directly. * Use host os instead of is_win. * Build engine artifacts for win. * Update build/archives/BUILD.gn Co-authored-by: Zachary Anderson <[email protected]> * Update build/archives/BUILD.gn Co-authored-by: Zachary Anderson <[email protected]> * Update build/archives/BUILD.gn Co-authored-by: Zachary Anderson <[email protected]> Co-authored-by: Zachary Anderson <[email protected]>

…lutter#115335) * 6976132e5 [web] Switch to doubles (flutter/engine#37336) * c3d7c5967 Roll Skia from a434f9b69660 to 33c62dafffc9 (9 revisions) (flutter/engine#37598) * 91656a5ff Avoid segfault when converting no-op ColorFilter to ImageFilter (flutter/engine#37596) * 965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414) * 16dba68e5 [Impeller] Only apply the rrect blur fast path for solid Colors (flutter/engine#37594) * d366183c0 Roll Dart SDK from 7cbcf48157cf to 6f5478a58387 (2 revisions) (flutter/engine#37597) * 88f56870b Roll Fuchsia Linux SDK from dRHIZSishiboEHMdw... to B0OuUvWOY24LI1WoF... (flutter/engine#37603) * 28eeba518 [Multiwindow, macOS] FlutterCompositor::Present receives view_id (flutter/engine#37391) * 8d815657c Roll Skia from 33c62dafffc9 to b474a43dcc34 (6 revisions) (flutter/engine#37606) * 78ae24140 Revert "[web] Switch to doubles (flutter#37336)" (flutter/engine#37609)

godofredoc requested review from zanderso and dnfield August 16, 2022 16:32

dnfield approved these changes Aug 17, 2022

View reviewed changes

zanderso suggested changes Aug 17, 2022

View reviewed changes

chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Aug 25, 2022

zanderso mentioned this pull request Oct 31, 2022

Add top-level target for Windows/Android gen_snapshot #37134

Merged

loic-sharma reviewed Nov 7, 2022

View reviewed changes

godofredoc added 17 commits November 9, 2022 22:44

Archive windows gen_snapshot.exe.

56e4e4a

This is required to enable engine_v2 recipes for windows platform. Bug: flutter/flutter#81855

Add dep to generate gen_snapshot.exe.

a420497

Use target platform name rather than host.

6beb5f3

Use prebuilt_arch.

76c0ed1

Use platform_name instead of is_win.

8c7b9d1

Remove android check.

1c7c55b

Fix output name.

28dde2c

Separate platform and cpu in name.

58946c4

Remove failing line.

6476c1e

Use dart_target_arch rather than target_cpu in windows.

5e8075f

Add dart_target_arch to scope.

34c6458

Add support for android_cpu.

74775c8

Fix android_cpu variable name.

fe04472

Rebase to ToT

5167ef2

Try to use target cpu directly.

05598a7

Use host os instead of is_win.

d186259

Build engine artifacts for win.

3307d80

godofredoc removed the Work in progress (WIP) Not ready (yet) for review! label Nov 14, 2022

zanderso reviewed Nov 14, 2022

View reviewed changes

build/archives/BUILD.gn Outdated Show resolved Hide resolved

build/archives/BUILD.gn Outdated Show resolved Hide resolved

build/archives/BUILD.gn Outdated Show resolved Hide resolved

godofredoc and others added 3 commits November 14, 2022 08:17

Update build/archives/BUILD.gn

b05e233

Co-authored-by: Zachary Anderson <[email protected]>

Update build/archives/BUILD.gn

3414a76

Co-authored-by: Zachary Anderson <[email protected]>

Update build/archives/BUILD.gn

2944b79

Co-authored-by: Zachary Anderson <[email protected]>

godofredoc mentioned this pull request Nov 14, 2022

Add archives to android aot engine. #37601

Merged

8 tasks

zanderso approved these changes Nov 14, 2022

View reviewed changes

godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022

auto-submit bot merged commit 965f87d into flutter:main Nov 14, 2022

engine-flutter-autoroll mentioned this pull request Nov 14, 2022

Roll Flutter Engine from 14ecaeb915e0 to 965f87d314b8 (4 revisions) flutter/flutter#115319

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

6f41445

engine-flutter-autoroll mentioned this pull request Nov 14, 2022

Roll Flutter Engine from 14ecaeb915e0 to 16dba68e525e (5 revisions) flutter/flutter#115323

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 14, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

5dcc930

engine-flutter-autoroll mentioned this pull request Nov 15, 2022

Roll Flutter Engine from 14ecaeb915e0 to d366183c03c9 (6 revisions) flutter/flutter#115326

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

3fc7941

engine-flutter-autoroll mentioned this pull request Nov 15, 2022

Roll Flutter Engine from 14ecaeb915e0 to 88f56870bb57 (7 revisions) flutter/flutter#115330

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

5b93585

engine-flutter-autoroll mentioned this pull request Nov 15, 2022

Roll Flutter Engine from 14ecaeb915e0 to 88f56870bb57 (7 revisions) flutter/flutter#115331

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

7fedc87

engine-flutter-autoroll mentioned this pull request Nov 15, 2022

Roll Flutter Engine from 14ecaeb915e0 to 28eeba518735 (8 revisions) flutter/flutter#115333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

28074f3

engine-flutter-autoroll mentioned this pull request Nov 15, 2022

Roll Flutter Engine from 14ecaeb915e0 to 78ae2414003a (10 revisions) flutter/flutter#115335

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022

965f87d31 Archive windows gen_snapshot.exe. (flutter/engine#35414)

8e93d58

godofredoc deleted the archive_win_gen branch March 8, 2023 16:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Archive windows gen_snapshot.exe. #35414

Archive windows gen_snapshot.exe. #35414

Uh oh!

godofredoc commented Aug 15, 2022

Uh oh!

zanderso Aug 17, 2022

Uh oh!

zanderso Aug 17, 2022

Uh oh!

zanderso Nov 7, 2022

Uh oh!

loic-sharma Nov 7, 2022

Uh oh!

pbo-linaro Nov 7, 2022

Uh oh!

godofredoc Nov 14, 2022

Uh oh!

godofredoc commented Nov 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

godofredoc commented Nov 14, 2022

Uh oh!

zanderso left a comment

Uh oh!

Uh oh!

Archive windows gen_snapshot.exe. #35414

Archive windows gen_snapshot.exe. #35414

Uh oh!

Conversation

godofredoc commented Aug 15, 2022

Pre-launch Checklist

Uh oh!

zanderso Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

zanderso Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

zanderso Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

loic-sharma Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

pbo-linaro Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

godofredoc Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

godofredoc commented Nov 14, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

godofredoc commented Nov 14, 2022

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!