This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables archives generation of gen_snapshot for windows AOT. Bug: flutter/flutter#81855
This depends on #35414 |
zanderso
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ question
], | ||
"name": "android_profile" | ||
} | ||
], | ||
"drone_dimensions": [], | ||
"gn": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is --goma
passed by default, or does it need to go in this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is added by default unless no_goma property is passed https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/build_util/api.py;l=31
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2022
…115387) * 9f000a13f Roll Dart SDK from 42f87c0521f8 to 8132f04a0b86 (2 revisions) (flutter/engine#37632) * 6dc4a6ad6 Add archives to android aot engine. (flutter/engine#37601) * 84cb1f833 Add ability to set entry-point for HLSL shaders (flutter/engine#37608)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
This enables archives generation of gen_snapshot for windows AOT. Bug: flutter/flutter#81855
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#115387) * 9f000a13f Roll Dart SDK from 42f87c0521f8 to 8132f04a0b86 (2 revisions) (flutter/engine#37632) * 6dc4a6ad6 Add archives to android aot engine. (flutter/engine#37601) * 84cb1f833 Add ability to set entry-point for HLSL shaders (flutter/engine#37608)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#115387) * 9f000a13f Roll Dart SDK from 42f87c0521f8 to 8132f04a0b86 (2 revisions) (flutter/engine#37632) * 6dc4a6ad6 Add archives to android aot engine. (flutter/engine#37601) * 84cb1f833 Add ability to set entry-point for HLSL shaders (flutter/engine#37608)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables archives generation of gen_snapshot for windows AOT.
Bug: flutter/flutter#81855
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.