Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add archives to android aot engine. #37601

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add archives to android aot engine. #37601

merged 1 commit into from
Nov 15, 2022

Conversation

godofredoc
Copy link
Contributor

This enables archives generation of gen_snapshot for windows AOT.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This enables archives generation of gen_snapshot for windows AOT.

Bug: flutter/flutter#81855
@godofredoc
Copy link
Contributor Author

This depends on #35414

@godofredoc godofredoc requested a review from zanderso November 15, 2022 00:00
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ question

],
"name": "android_profile"
}
],
"drone_dimensions": [],
"gn": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is --goma passed by default, or does it need to go in this list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 15, 2022
@auto-submit auto-submit bot merged commit 6dc4a6a into flutter:main Nov 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 15, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 15, 2022
…115387)

* 9f000a13f Roll Dart SDK from 42f87c0521f8 to 8132f04a0b86 (2 revisions) (flutter/engine#37632)

* 6dc4a6ad6 Add archives to android aot engine. (flutter/engine#37601)

* 84cb1f833 Add ability to set entry-point for HLSL shaders (flutter/engine#37608)
schwa423 pushed a commit to schwa423/engine that referenced this pull request Nov 16, 2022
This enables archives generation of gen_snapshot for windows AOT.

Bug: flutter/flutter#81855
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115387)

* 9f000a13f Roll Dart SDK from 42f87c0521f8 to 8132f04a0b86 (2 revisions) (flutter/engine#37632)

* 6dc4a6ad6 Add archives to android aot engine. (flutter/engine#37601)

* 84cb1f833 Add ability to set entry-point for HLSL shaders (flutter/engine#37608)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115387)

* 9f000a13f Roll Dart SDK from 42f87c0521f8 to 8132f04a0b86 (2 revisions) (flutter/engine#37632)

* 6dc4a6ad6 Add archives to android aot engine. (flutter/engine#37601)

* 84cb1f833 Add ability to set entry-point for HLSL shaders (flutter/engine#37608)
@godofredoc godofredoc deleted the add_artifacts_win branch March 8, 2023 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants