Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Remove dead code from FlutterWindow tests #39216

Merged
merged 1 commit into from
Jan 30, 2023
Merged

[Windows] Remove dead code from FlutterWindow tests #39216

merged 1 commit into from
Jan 30, 2023

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jan 28, 2023 •
edited
Loading

Removes dead code in the FlutterWindow unit tests.

Part of flutter/flutter#115611

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma marked this pull request as ready for review January 28, 2023 01:47
@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2023
@auto-submit auto-submit bot merged commit 033514b into flutter:main Jan 30, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
033514b3d [Windows] Remove dead code from FlutterWindow tests (flutte…
096135a 
…r/engine#39216)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 31, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 5011144c0b46 to daa8eeb7fc0b (2 revisions) (#…
865dc5c 
…119584)

* 033514b3d [Windows] Remove dead code from FlutterWindow tests (flutter/engine#39216)

* daa8eeb7f [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests (flutter/engine#39209)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yaakovschectman yaakovschectman yaakovschectman approved these changes

@dkwingsmt dkwingsmt Awaiting requested review from dkwingsmt

@cbracken cbracken Awaiting requested review from cbracken

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic-sharma @yaakovschectman