Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Update font fallback data #40402

Closed
wants to merge 3 commits into from
Closed

[web] Update font fallback data #40402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0828558
[web] Update font fallback data
mdebbar Mar 17, 2023
cf83d6b
fix test
mdebbar Mar 20, 2023
0edfce1
Merge branch 'main' into update_fallback_fonts
mdebbar Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/web_ui/dev/generate_fallback_font_data.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ class GenerateFallbackFontDataCommand extends Command<bool>
}
for (final String family in fallbackFonts) {
print('Downloading $family...');
if (urlForFamily[family] == null) {
throw ToolExit('No URL found for "$family"');
}
final Uri uri = urlForFamily[family]!;
final http.Response fontResponse = await client.get(uri);
if (fontResponse.statusCode != 200) {
Expand Down Expand Up @@ -242,7 +245,7 @@ const List<String> fallbackFonts = <String>[
'Noto Sans Mro',
'Noto Sans Multani',
'Noto Sans Myanmar',
'Noto Sans N Ko',
'Noto Sans NKo',
'Noto Sans Nabataean',
'Noto Sans New Tai Lue',
'Noto Sans Newa',
Expand Down
30 changes: 15 additions & 15 deletions lib/web_ui/lib/src/engine/canvaskit/font_fallback_data.dart
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/web_ui/test/canvaskit/fallback_fonts_golden_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ void testMain() {
'Noto Sans Mro',
'Noto Sans Multani',
'Noto Sans Myanmar',
'Noto Sans N Ko',
'Noto Sans NKo',
'Noto Sans Nabataean',
'Noto Sans New Tai Lue',
'Noto Sans Newa',
Expand Down