Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Update font fallback data #40402

Closed
wants to merge 3 commits into from

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 17, 2023

The main reason for the update is that Noto Sans N Ko was renamed to Noto Sans NKo in Google Fonts API.

@mdebbar mdebbar requested a review from harryterkelsen March 17, 2023 21:35
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 17, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@mdebbar
Copy link
Contributor Author

mdebbar commented Mar 29, 2023

Closing in favor of #40666

@mdebbar mdebbar closed this Mar 29, 2023
@mdebbar mdebbar deleted the update_fallback_fonts branch June 22, 2023 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant