Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Switch from Noto Emoji to Noto Color Emoji and update font data #40666

Merged
merged 8 commits into from
Mar 29, 2023

Conversation

harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Mar 27, 2023

Use Noto Color Emoji instead of Noto Emoji for the default Emoji fallback font. These emoji look much nicer than the black and white variants.

Fixes flutter/flutter#119536

Before:
Screenshot 2023-03-27 at 9 52 52 AM

After:
Screenshot 2023-03-27 at 10 11 25 AM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 27, 2023
@harryterkelsen harryterkelsen requested a review from yjbanov March 27, 2023 17:16
@lublak
Copy link

lublak commented Mar 28, 2023

@hterkelsen but I think it will not fix the whole issue.
Windows desktop does not use this font at all. Neither the black and white nor the colored one.

Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I did the font fallback update here but I guess it's redundant now so I'll close my PR :)

@harryterkelsen
Copy link
Contributor Author

@hterkelsen but I think it will not fix the whole issue. Windows desktop does not use this font at all. Neither the black and white nor the colored one.

The referenced issue is only for web. Please file a separate issue for Windows desktop emoji bugs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web][3.7] Emojis are not properly rendered
3 participants