This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move ownership of AccessibilityBridgeWindows to FlutterWindowsView
#41308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
commented
Apr 18, 2023
| @@ -200,10 +201,18 @@ class FlutterWindowsView : public WindowBindingHandlerDelegate, | |||
| // |WindowBindingHandlerDelegate| | |||
| virtual ui::AXFragmentRootDelegateWin* GetAxFragmentRootDelegate() override; | |||
|
|
|||
| // Called to re/set the accessibility bridge pointer. | |||
| virtual void UpdateSemanticsEnabled(bool enabled); | |||
There was a problem hiding this comment.
The content of this new method could have instead been placed in OnUpdateSemanticsEnabled, which is what calls FlutterWindowsEngine::UpdateSemanticsEnabled. However, once we have multiple views, a call to OnUpdateSemanticsEnabled on a view would not necessarily call it for other views.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
loic-sharma
reviewed
Apr 19, 2023
dkwingsmt
reviewed
Apr 19, 2023
shell/platform/windows/accessibility_bridge_windows_unittests.cc
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 21, 2023
…125271) flutter/engine@2db85cb...122c3b3 2023-04-21 [email protected] [Windows] Don't block raster thread until v-blank (flutter/engine#41231) 2023-04-21 [email protected] Manual roll skia to d5b4acfb4 (flutter/engine#41378) 2023-04-21 [email protected] Run mac unopt arm builds with arm toolchain (flutter/engine#41353) 2023-04-20 [email protected] Revert "re-land "Migrate mac_host_engine to engine v2 builds." (#41233)"" (flutter/engine#41380) 2023-04-20 [email protected] Roll Dart SDK from df05e451b79a to 50b96abe9f6f (1 revision) (flutter/engine#41379) 2023-04-20 [email protected] Move ownership of `AccessibilityBridgeWindows` to `FlutterWindowsView` (flutter/engine#41308) 2023-04-20 [email protected] Roll Fuchsia Linux SDK from AoPEjX8Xfq1v0h4kx... to PqBDstaESE_l77k1e... (flutter/engine#41373) 2023-04-20 [email protected] Revert "Upload windows arm artifacts to production bucket." (flutter/engine#41372) 2023-04-20 [email protected] re-land "Migrate mac_host_engine to engine v2 builds." (#41233)" (flutter/engine#41323) 2023-04-20 [email protected] Upload windows arm artifacts to production bucket. (flutter/engine#41324) 2023-04-20 [email protected] [Impeller] Change the default color format for the GLES backend to RGBA (flutter/engine#41342) 2023-04-20 [email protected] [web] change status bar color based on SystemUiOverlayStyle (flutter/engine#40599) 2023-04-20 [email protected] Roll Fuchsia Mac SDK from OcPCdaE17MAihaCrD... to 4OrPF9lzqCKGwBLRh... (flutter/engine#41367) 2023-04-20 [email protected] Roll Skia from fc09f9b2fb27 to f4609aa2eaba (1 revision) (flutter/engine#41366) 2023-04-20 [email protected] Roll Dart SDK from 7d165bd0bb5e to df05e451b79a (2 revisions) (flutter/engine#41365) 2023-04-20 [email protected] Roll Skia from 80c38970791e to fc09f9b2fb27 (1 revision) (flutter/engine#41362) 2023-04-20 [email protected] Roll Skia from c50081c62219 to 80c38970791e (2 revisions) (flutter/engine#41360) 2023-04-20 [email protected] Roll Skia from c21e7df194c3 to c50081c62219 (11 revisions) (flutter/engine#41358) 2023-04-20 [email protected] Roll Fuchsia Linux SDK from Tun7i4VLz6ncx8JJJ... to AoPEjX8Xfq1v0h4kx... (flutter/engine#41357) 2023-04-20 [email protected] Roll Dart SDK from 88a3b66b50d6 to 7d165bd0bb5e (1 revision) (flutter/engine#41356) 2023-04-20 [email protected] Manual Skia roll from ad90b6bd4760 to c21e7df194c3 (flutter/engine#41341) 2023-04-20 [email protected] [impeller] convert src over to src for solid color (flutter/engine#41351) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Tun7i4VLz6nc to PqBDstaESE_l fuchsia/sdk/core/mac-amd64 from OcPCdaE17MAi to 4OrPF9lzqCKG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
The ownership of the accessibility bridge was moved from `FlutterWindowsEngine` to `FlutterWindowsView`. This change moves leftover accessibility bridge helpers/logic from the engine to the view. Addresses: flutter/flutter#124995 Follow-up to: #41308 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
…r#43710) The ownership of the accessibility bridge was moved from `FlutterWindowsEngine` to `FlutterWindowsView`. This change moves leftover accessibility bridge helpers/logic from the engine to the view. Addresses: flutter/flutter#124995 Follow-up to: flutter#41308 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move ownership of the pointer to
AccessibilityBridgeWindowsfromFlutterWindowsEnginetoFlutterWindowsViewin preparation for multi-window.flutter/flutter#124995
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.