This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Remove accessibility bridge helpers from the engine #43710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
changed the title
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 17, 2023
…130758) flutter/engine@15c15fd...09689d3 2023-07-17 [email protected] [Windows] Remove accessibility bridge helpers from the engine (flutter/engine#43710) 2023-07-17 [email protected] Move Dart licenses into a separate golden file (flutter/engine#43289) 2023-07-17 [email protected] Roll Skia from f29d58569c67 to f2a4222bb72e (1 revision) (flutter/engine#43746) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Jul 20, 2023
…r#43710) The ownership of the accessibility bridge was moved from `FlutterWindowsEngine` to `FlutterWindowsView`. This change moves leftover accessibility bridge helpers/logic from the engine to the view. Addresses: flutter/flutter#124995 Follow-up to: flutter#41308 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…lutter#130758) flutter/engine@15c15fd...09689d3 2023-07-17 [email protected] [Windows] Remove accessibility bridge helpers from the engine (flutter/engine#43710) 2023-07-17 [email protected] Move Dart licenses into a separate golden file (flutter/engine#43289) 2023-07-17 [email protected] Roll Skia from f29d58569c67 to f2a4222bb72e (1 revision) (flutter/engine#43746) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ownership of the accessibility bridge was moved from
FlutterWindowsEnginetoFlutterWindowsView. This change moves leftover accessibility bridge helpers/logic from the engine to the view.Addresses: flutter/flutter#124995
Follow-up to: #41308
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.