Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ios_platform_view] Remove platform view if a duplicate is created. #41708

Closed
wants to merge 2 commits into from

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented May 3, 2023

Fixes flutter/flutter#125913

The fix in this PR is to remove the duplicate PlatformView from the view tree.
See description in the above issue for details.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cyanglaz cyanglaz requested a review from hellohuanlin May 3, 2023 19:55
@cyanglaz cyanglaz marked this pull request as ready for review May 3, 2023 19:55
@chinmaygarde
Copy link
Member

Ping @hellohuanlin

@hellohuanlin
Copy link
Contributor

we sync'ed offline about this PR, and will need to think more about whether to patch the engine, or fix the race in the scenario test which is the root cause

@cyanglaz
Copy link
Contributor Author

Closing this one for now, I will create a PR to fix the scenario test first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS PlatformViewsController needs to be more resilient when creating the same view multiple times.
3 participants