Skip to content

Engine test PlatformViewMutationClipRectAfterMovedTests testPlatformView failing in CI on macOS 13 #137547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vashworth opened this issue Oct 30, 2023 · 8 comments · Fixed by flutter/engine#47575
Assignees
Labels
engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team

Comments

@vashworth
Copy link
Contributor

vashworth commented Oct 30, 2023

Test Case '-[PlatformViewMutationClipRectAfterMovedTests testPlatformView]' started.
    t =     0.00s Start Test at 2023-10-29 19:45:18.660
    t =     0.00s Set Up
    t =     0.00s     Open dev.flutter.Scenarios
    t =     0.00s         Launch dev.flutter.Scenarios
    t =     0.00s             Terminate dev.flutter.Scenarios:32972
    t =     1.24s             Setting up automation session
    t =     1.51s             Wait for dev.flutter.Scenarios to idle
    t =     2.57s Waiting 30.0s for "platform_view[10000]" Other to exist
    t =     3.61s     Checking `Expect predicate `exists == 1` for object "platform_view[10000]" Other`
    t =     3.61s         Checking existence of `"platform_view[10000]" Other`
    t =     3.67s Waiting 30.0s for TextView to exist
    t =     4.72s     Checking `Expect predicate `exists == 1` for object TextView`
    t =     4.73s         Checking existence of `TextView`
2023-10-29 19:45:23.464005-0700 ScenariosUITests-Runner[32882:184235] GOLDEN DIFF FAILED: image diff greater than threshold. Current diff: 11.53593182792057, threshold: 0.5
    t =     4.83s Added attachment named 'golden_platform_view_cliprect_after_moved_iPhone SE (3rd generation)_16.2_simulator_actual.png'
/Volumes/Work/s/w/ir/cache/builder/src/out/ios_debug_sim_arm64_extension_safe/scenario_app/Scenarios/ScenariosUITests/GoldenTestManager.m:103: error: -[PlatformViewMutationClipRectAfterMovedTests testPlatformView] : failed - Goldens do not match. Follow the steps in the README to update golden named golden_platform_view_cliprect_after_moved_iPhone SE (3rd generation)_16.2_simulator if needed.
    t =     4.90s Tear Down
Test Case '-[PlatformViewMutationClipRectAfterMovedTests testPlatformView]' failed (5.102 seconds).
Test Suite 'PlatformViewMutationClipRectAfterMovedTests' failed at 2023-10-29 19:45:23.762.

It seems to only fail sometimes on ios_debug_sim_arm64_extension_safe and ios_debug_sim_arm64

ios_debug_sim_arm64_extension_safe
passing:
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/10946/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/10958/overview (failed the first time, passed the second)
failing:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/480262/overview

ios_debug_sim_arm64
failing:
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/10957/overview
https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/10945/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/480261/overview (ignore cancellation, if you look at the stdout of step 29, you'll see test failed)

@vashworth vashworth added platform-ios iOS applications specifically engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list team-ios Owned by iOS platform team labels Oct 30, 2023
@vashworth
Copy link
Contributor Author

@cyanglaz Can you take a look at this?

@cyanglaz
Copy link
Contributor

Note to self: screenshot for https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/10957/overview
(Other failures look similar)

golden_platform_view_cliprect_after_moved_iPhone SE (3rd generation)_16 2_simulator_actual

@cyanglaz
Copy link
Contributor

Oh This is on Mac13, I already updated my mac to 14. @hellohuanlin Do you have your mac still on 13?

@cyanglaz
Copy link
Contributor

'/Volumes/Work/s/w/ir/cache/osx_sdk/xcode_14e300c_runtime_ios-16-4_14e300c_ios-16-2_14c18/XCode.app' This is the xcode version.

@hellohuanlin
Copy link
Contributor

Yep im still on 13. i can take a look when get time

@cyanglaz
Copy link
Contributor

cyanglaz commented Nov 1, 2023

I think the test hit this bug: #126627
Which I have created a seperate bug to track the engine fix: #125913

@cyanglaz
Copy link
Contributor

cyanglaz commented Nov 1, 2023

Potential engine fix: flutter/engine#41708

auto-submit bot pushed a commit to flutter/engine that referenced this issue Nov 2, 2023
Fixes race condition in Platform View Scenario tests, see flutter/flutter#126627 for description of issue.

Fixes flutter/flutter#137547 and flutter/flutter#126627.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels. P1 High-priority issues at the top of the work list platform-ios iOS applications specifically team-ios Owned by iOS platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants