Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Set xcode explicitly on mac builds with release_build. #42898

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Set xcode explicitly on mac builds with release_build. #42898

merged 1 commit into from
Jun 16, 2023

Conversation

godofredoc
Copy link
Contributor

Xcode version needs to be set explicitly for builds running on dart-internal.

Bug: flutter/flutter#128977

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Set xcode explicitly on mac builds with release_build.
d10569f 
Xcode version needs to be set explicitly for builds running on
dart-internal.

Bug: flutter/flutter#128977
@godofredoc godofredoc requested a review from keyonghan June 16, 2023 00:02
keyonghan
keyonghan approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 16, 2023
@godofredoc godofredoc merged commit 83bf87f into flutter:main Jun 16, 2023
@godofredoc godofredoc deleted the explicit_xcode branch June 16, 2023 05:04
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
22326b0 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
8d24cc3 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
1a8c97a 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
d136954 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
775a778 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
b79d6aa 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
aaa0de0 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
73e2b21 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
78a6aa4 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
49a5d90 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
ceb896e 
…tter/engine#42898)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
83bf87f7c Set xcode explicitly on mac builds with release_build. (flu…
75ff257 
…tter/engine#42898)
gaaclarke pushed a commit to flutter/flutter that referenced this pull request Jun 16, 2023
@engine-flutter-autoroll
Roll Flutter Engine from fb5fed432e59 to aefe104cd067 (21 revisions) (#…
5a7ab5a 
…129029)

flutter/engine@fb5fed4...aefe104

2023-06-16 [email protected] Revert "Add
deprecations to PlatformMessage stuff" (flutter/engine#42921)
2023-06-16 [email protected] add dart_internal override where necessary
(flutter/engine#42920)
2023-06-16 [email protected] Roll Skia from d43262e90f25 to
a4ad5b369313 (3 revisions) (flutter/engine#42919)
2023-06-16 [email protected] Roll Skia from 9ab04a53b7be to
d43262e90f25 (5 revisions) (flutter/engine#42918)
2023-06-16 [email protected] [web] Move webOnlyAssetManager to
`dart:ui_web` (flutter/engine#42642)
2023-06-16 [email protected] Roll Fuchsia Linux SDK from
E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915)
2023-06-16 [email protected] Roll Fuchsia Mac SDK from
FJPPnZP9EcGLQ0OZa... to fXVcR5tdj5wSd_OUz... (flutter/engine#42912)
2023-06-16 [email protected] Roll Skia from c29ecbe7fba7 to
9ab04a53b7be (1 revision) (flutter/engine#42910)
2023-06-16 [email protected] Roll Skia from 504a26e85fc6 to
c29ecbe7fba7 (1 revision) (flutter/engine#42909)
2023-06-16 [email protected] Roll Skia from f0410a265d2b to
504a26e85fc6 (1 revision) (flutter/engine#42907)
2023-06-16 [email protected] Set xcode explicitly on mac builds with
release_build. (flutter/engine#42898)
2023-06-16 [email protected] Fix prefer_final_in_for_each
(flutter/engine#42899)
2023-06-16 [email protected] Roll Skia from abfa3505db23 to
f0410a265d2b (1 revision) (flutter/engine#42904)
2023-06-16 [email protected] Remove release_build from clang_tidy
build. (flutter/engine#42900)
2023-06-16 [email protected] Roll Fuchsia Linux SDK from
53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897)
2023-06-15 [email protected] Revert "Roll Clang from 6d667d4b261e to
7f374b6902fa" (flutter/engine#42896)
2023-06-15 [email protected] Roll Skia from 2ab2678058a3 to
abfa3505db23 (1 revision) (flutter/engine#42894)
2023-06-15 [email protected] Roll Fuchsia Mac SDK from
P7QA6bfO_Ij5dre7B... to FJPPnZP9EcGLQ0OZa... (flutter/engine#42892)
2023-06-15 [email protected] Roll Skia from 794b6f9240a8 to
2ab2678058a3 (6 revisions) (flutter/engine#42889)
2023-06-15 [email protected] Add deprecations to PlatformMessage
stuff (flutter/engine#42580)
2023-06-15 [email protected] [Impeller] Joined
obligatory vulkan swapchain submits (flutter/engine#42865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 53EjCyuRu91o to -NW1eatBbmjv
  fuchsia/sdk/core/mac-amd64 from P7QA6bfO_Ij5 to fXVcR5tdj5wS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keyonghan keyonghan keyonghan approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @keyonghan