This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix prefer_final_in_for_each #42899
Merged
Fix prefer_final_in_for_each #42899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jason-simmons
approved these changes
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 16, 2023
gaaclarke
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 16, 2023
…129029) flutter/engine@fb5fed4...aefe104 2023-06-16 [email protected] Revert "Add deprecations to PlatformMessage stuff" (flutter/engine#42921) 2023-06-16 [email protected] add dart_internal override where necessary (flutter/engine#42920) 2023-06-16 [email protected] Roll Skia from d43262e90f25 to a4ad5b369313 (3 revisions) (flutter/engine#42919) 2023-06-16 [email protected] Roll Skia from 9ab04a53b7be to d43262e90f25 (5 revisions) (flutter/engine#42918) 2023-06-16 [email protected] [web] Move webOnlyAssetManager to `dart:ui_web` (flutter/engine#42642) 2023-06-16 [email protected] Roll Fuchsia Linux SDK from E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915) 2023-06-16 [email protected] Roll Fuchsia Mac SDK from FJPPnZP9EcGLQ0OZa... to fXVcR5tdj5wSd_OUz... (flutter/engine#42912) 2023-06-16 [email protected] Roll Skia from c29ecbe7fba7 to 9ab04a53b7be (1 revision) (flutter/engine#42910) 2023-06-16 [email protected] Roll Skia from 504a26e85fc6 to c29ecbe7fba7 (1 revision) (flutter/engine#42909) 2023-06-16 [email protected] Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision) (flutter/engine#42907) 2023-06-16 [email protected] Set xcode explicitly on mac builds with release_build. (flutter/engine#42898) 2023-06-16 [email protected] Fix prefer_final_in_for_each (flutter/engine#42899) 2023-06-16 [email protected] Roll Skia from abfa3505db23 to f0410a265d2b (1 revision) (flutter/engine#42904) 2023-06-16 [email protected] Remove release_build from clang_tidy build. (flutter/engine#42900) 2023-06-16 [email protected] Roll Fuchsia Linux SDK from 53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897) 2023-06-15 [email protected] Revert "Roll Clang from 6d667d4b261e to 7f374b6902fa" (flutter/engine#42896) 2023-06-15 [email protected] Roll Skia from 2ab2678058a3 to abfa3505db23 (1 revision) (flutter/engine#42894) 2023-06-15 [email protected] Roll Fuchsia Mac SDK from P7QA6bfO_Ij5dre7B... to FJPPnZP9EcGLQ0OZa... (flutter/engine#42892) 2023-06-15 [email protected] Roll Skia from 794b6f9240a8 to 2ab2678058a3 (6 revisions) (flutter/engine#42889) 2023-06-15 [email protected] Add deprecations to PlatformMessage stuff (flutter/engine#42580) 2023-06-15 [email protected] [Impeller] Joined obligatory vulkan swapchain submits (flutter/engine#42865) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 53EjCyuRu91o to -NW1eatBbmjv fuchsia/sdk/core/mac-amd64 from P7QA6bfO_Ij5 to fXVcR5tdj5wS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://dart-review.googlesource.com/c/sdk/+/309821