Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert dl split #45326

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Revert dl split #45326

merged 2 commits into from
Aug 31, 2023

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Aug 31, 2023

Reverting for flutter/flutter#133525
fixes: #45326

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 31, 2023

auto label is removed for flutter/engine/45326, due to - The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed through a number of commit bisects

@auto-submit auto-submit bot merged commit 7a2eaf4 into flutter:main Aug 31, 2023
@zanderso zanderso deleted the revert-dl-split branch August 31, 2023 17:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2023
…133810)

flutter/engine@51090e3...ca513c9

2023-08-31 [email protected] Revert "Reland "Build iOS unittest target in unopt builds" (#44356)"" (flutter/engine#45346)
2023-08-31 [email protected] Lazily allocate RasterCacheItems only when caching is enabled (flutter/engine#45211)
2023-08-31 [email protected] Roll Skia from 8ff4fd208c26 to 5d08dadd2ef4 (3 revisions) (flutter/engine#45340)
2023-08-31 [email protected] Reland "Build iOS unittest target in unopt builds" (#44356)" (flutter/engine#44821)
2023-08-31 [email protected] Update comment const_finder.dart (flutter/engine#45180)
2023-08-31 [email protected] Replace an unnecessary util function with PostSync (flutter/engine#45190)
2023-08-31 [email protected] Roll Skia from cda0cfaadfd7 to 8ff4fd208c26 (3 revisions) (flutter/engine#45337)
2023-08-31 [email protected] Roll Dart SDK from 0cea73a8d3c3 to ac3bc9f6351a (4 revisions) (flutter/engine#45336)
2023-08-31 [email protected] [macOS] Link __availability_version_check (flutter/engine#45333)
2023-08-31 [email protected] Roll Skia from 8c05d5103d6b to cda0cfaadfd7 (3 revisions) (flutter/engine#45334)
2023-08-31 [email protected] Adds an --rbe option to tools/gn that works on Linux hosts (flutter/engine#45271)
2023-08-31 [email protected] Migrate VK calls of GrBackend* (flutter/engine#45325)
2023-08-31 [email protected] Roll buildroot (flutter/engine#45329)
2023-08-31 [email protected] Revert dl split (flutter/engine#45326)
2023-08-31 [email protected] Roll Skia from d113402de2ce to 8c05d5103d6b (4 revisions) (flutter/engine#45331)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dnfield added a commit to dnfield/engine that referenced this pull request Sep 1, 2023
@flar
Copy link
Contributor

flar commented Sep 8, 2023

Reverted PR: #45085
Reverted commit: zanderso@a3936c2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-android platform-ios
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants