Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Reland "Build iOS unittest target in unopt builds" (#44356)"" #45346

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Revert "Reland "Build iOS unittest target in unopt builds" (#44356)"" #45346

merged 1 commit into from
Aug 31, 2023

Conversation

zanderso
Copy link
Member

@zanderso zanderso requested review from cyanglaz and gaaclarke August 31, 2023 20:46
@zanderso
Copy link
Member Author

zanderso commented Aug 31, 2023 •
edited
Loading

Looks like the presubs were green (but stale) when this landed.

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Aug 31, 2023
@gaaclarke
Copy link
Member

Yea, one of those interesting cases where the changed files aren't changed but causes clang-tidy failures. @zanderso maybe we can run full tidy if a BUILD.gn file is changed?

@zanderso zanderso merged commit ca513c9 into main Aug 31, 2023
@zanderso zanderso deleted the revert-44821-reland_unittest_target_unopt_build branch August 31, 2023 21:05
@zanderso
Copy link
Member Author

Yea, one of those interesting cases where the changed files aren't changed but causes clang-tidy failures. @zanderso maybe we can run full tidy if a BUILD.gn file is changed?

Yeah, we'd have to add logic to the clang_tidy wrapper for that since the .ci.yaml filters aren't expressive enough.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
ca513c999 Revert "Reland "Build iOS unittest target in unopt builds" (f…
801d323 
…lutter#44356)"" (flutter/engine#45346)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 51090e3cfe79 to ca513c999257 (15 revisions) (#…
7ade163 
…133810)

flutter/engine@51090e3...ca513c9

2023-08-31 [email protected] Revert "Reland "Build iOS unittest target in unopt builds" (#44356)"" (flutter/engine#45346)
2023-08-31 [email protected] Lazily allocate RasterCacheItems only when caching is enabled (flutter/engine#45211)
2023-08-31 [email protected] Roll Skia from 8ff4fd208c26 to 5d08dadd2ef4 (3 revisions) (flutter/engine#45340)
2023-08-31 [email protected] Reland "Build iOS unittest target in unopt builds" (#44356)" (flutter/engine#44821)
2023-08-31 [email protected] Update comment const_finder.dart (flutter/engine#45180)
2023-08-31 [email protected] Replace an unnecessary util function with PostSync (flutter/engine#45190)
2023-08-31 [email protected] Roll Skia from cda0cfaadfd7 to 8ff4fd208c26 (3 revisions) (flutter/engine#45337)
2023-08-31 [email protected] Roll Dart SDK from 0cea73a8d3c3 to ac3bc9f6351a (4 revisions) (flutter/engine#45336)
2023-08-31 [email protected] [macOS] Link __availability_version_check (flutter/engine#45333)
2023-08-31 [email protected] Roll Skia from 8c05d5103d6b to cda0cfaadfd7 (3 revisions) (flutter/engine#45334)
2023-08-31 [email protected] Adds an --rbe option to tools/gn that works on Linux hosts (flutter/engine#45271)
2023-08-31 [email protected] Migrate VK calls of GrBackend* (flutter/engine#45325)
2023-08-31 [email protected] Roll buildroot (flutter/engine#45329)
2023-08-31 [email protected] Revert dl split (flutter/engine#45326)
2023-08-31 [email protected] Roll Skia from d113402de2ce to 8c05d5103d6b (4 revisions) (flutter/engine#45331)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Sep 6, 2023
Revert "Revert "Reland "Build iOS unittest target in unopt builds" (f…
4383231 
…lutter#44356)"" (flutter#45346)"

This reverts commit ca513c9.
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Sep 7, 2023
Revert "Revert "Reland "Build iOS unittest target in unopt builds" (f…
11e04bc 
…lutter#44356)"" (flutter#45346)"

This reverts commit ca513c9.

fix 1

fix

fix

temp ci change

fix name space

fix

fix

fix

format
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Sep 8, 2023
Revert "Revert "Reland "Build iOS unittest target in unopt builds" (f…
4b9a384 
…lutter#44356)"" (flutter#45346)"

This reverts commit ca513c9.

fix 1

fix

fix

temp ci change

fix name space

fix

fix

fix

format
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Sep 8, 2023
Revert "Revert "Reland "Build iOS unittest target in unopt builds" (f…
b3cfd92 
…lutter#44356)"" (flutter#45346)"

This reverts commit ca513c9.

fix 1

fix

fix

temp ci change

fix name space

fix

fix

fix

format

revert

fix

draft

fix unittest

fix

fromat

eof line
auto-submit bot pushed a commit that referenced this pull request Sep 12, 2023
Reland "Build iOS unittest target in unopt builds" (#44356)"" (#45346)…
eab8b71 
…" (#45519)

Reland #44821

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanderso @gaaclarke @cyanglaz