This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add warning about Vulkan queue usage in embedder.h #45731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
suggested changes
Sep 12, 2023
|
Does the docstring look good? This just adds a docstring and doesn't need a unittest. I'm OK to hold off though, no strong opinions here. |
I'm minutes from posting the PR as we discussed in our meeting. I have something different written up that documents queue and the proc callback, plus it has the test that asserts it works. |
|
Here is the PR with the test (#45732). |
|
Closing in favor of #45732. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warning that suggests the workaround inline and points to flutter/flutter#134573.
Aside from this, we could also update our GLFW example embedder to employ this workaround (providing an explicit code sample that users may reference/copy).