Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Added test to assert the vulkan embedder threadsafe vkqueue usage #45732

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Added test to assert the vulkan embedder threadsafe vkqueue usage #45732

merged 3 commits into from
Sep 12, 2023

Conversation

gaaclarke
Copy link
Member

fixes flutter/flutter#133933

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke mentioned this pull request Sep 12, 2023
Closed
@gaaclarke gaaclarke requested a review from bdero September 12, 2023 20:33
bdero
bdero approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shell/platform/embedder/embedder.h
@@ -757,6 +757,9 @@ typedef struct {
/// The queue family index of the VkQueue supplied in the next field.
uint32_t queue_family_index;
/// VkQueue handle.
/// The queue should not be used without protection from a mutex to make sure
/// it is not used simultaneously with other threads. That mutex should match
/// the one injected via the |get_instance_proc_address_callback|.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to flutter/flutter#134573 (bug about fixing this behavior)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

cbracken
cbracken approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a small suggestion

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot merged commit f358bde into flutter:main Sep 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
f358bde6c Added test to assert the vulkan embedder threadsafe vkqueue…
0ad1c8f 
… usage (flutter/engine#45732)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
Roll Flutter Engine from c90fadf45d44 to 7c78ea210c19 (10 revisions) (#…
68ce499 
…134597)

flutter/engine@c90fadf...7c78ea2

2023-09-12 [email protected] Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734)
2023-09-12 [email protected] Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744)
2023-09-12 [email protected] [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739)
2023-09-12 [email protected] [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740)
2023-09-12 [email protected] Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738)
2023-09-12 [email protected] [ios] upload extension safe artifacts (flutter/engine#45664)
2023-09-12 [email protected] Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732)
2023-09-12 [email protected] [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674)
2023-09-12 [email protected] Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729)
2023-09-12 [email protected] Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll @Mairramer
Roll Flutter Engine from c90fadf45d44 to 7c78ea210c19 (10 revisions) (f…
e608579 
…lutter#134597)

flutter/engine@c90fadf...7c78ea2

2023-09-12 [email protected] Revert "Lazily allocate RasterCacheItems only when caching is enabled" (flutter/engine#45734)
2023-09-12 [email protected] Revert "Use a single OffscreenCanvas for rendering in CanvasKit" (flutter/engine#45744)
2023-09-12 [email protected] [Impeller] Patch the compiler to account for subpass inputs and PSO metadata. (flutter/engine#45739)
2023-09-12 [email protected] [Impeller] Fix swapchain recreation for non-polling cases. (flutter/engine#45740)
2023-09-12 [email protected] Roll Fuchsia Mac SDK from QgAHx3BtJfN3TmodS... to UCa49z8fu0hD9cypj... (flutter/engine#45738)
2023-09-12 [email protected] [ios] upload extension safe artifacts (flutter/engine#45664)
2023-09-12 [email protected] Added test to assert the vulkan embedder threadsafe vkqueue usage (flutter/engine#45732)
2023-09-12 [email protected] [Impeller] If validations are enabled but not found, still create the VK context. (flutter/engine#45674)
2023-09-12 [email protected] Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729)
2023-09-12 [email protected] Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from QgAHx3BtJfN3 to UCa49z8fu0hD

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde chinmaygarde is a code owner

2 more reviewers

@cbracken cbracken cbracken approved these changes

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flutter engine may invoke vkQueueSubmit from the io thread
3 participants
@gaaclarke @cbracken @bdero