Fix race condition in Platform View Scenario tests #47575
Conversation
|
I also validated it passed on macOS 13 https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac%20Engine%20Drone/11097/overview 🎉 |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
vashworth
added
the
autosubmit
…137774) flutter/engine@be49d65...16d54bd 2023-11-02 [email protected] Fix race condition in Platform View Scenario tests (flutter/engine#47575) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes race condition in Platform View Scenario tests, see flutter/flutter#126627 for description of issue.
Fixes flutter/flutter#137547 and flutter/flutter#126627.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.