This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Delete tessellation control/eval shader support. #48649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Dec 5, 2023
| @@ -63,10 +59,6 @@ static std::optional<uint32_t> ToJsonStage(spv::ExecutionModel stage) { | |||
| return 1; // fb::Stage::kFragment; | |||
| case spv::ExecutionModel::ExecutionModelGLCompute: | |||
| return 2; // fb::Stage::kCompute; | |||
| case spv::ExecutionModel::ExecutionModelTessellationControl: | |||
There was a problem hiding this comment.
Unrelated to this patch: This is a bit of an odd API, can this just return std::optional<spv::ExecutionModel> instead of the desugared int. Then the caller can cast it to an int. That way, we don't have to match fb::Stage::kVertex to 0 and so on. In case we change the .fbs to change the order, we won't know we broke this here.
The ToStage method above does this correctly IMO.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 5, 2023
…139583) flutter/engine@7133378...cfdaecc 2023-12-05 [email protected] A11y enabled state (flutter/engine#48653) 2023-12-05 [email protected] Roll Skia from bf1db1c75704 to c0ad3e9bdec0 (1 revision) (flutter/engine#48685) 2023-12-05 [email protected] [Impeller] started taking into account integer gaps in blur sigma, turned on linear filter (flutter/engine#48651) 2023-12-05 [email protected] Roll Dart SDK from 21574eae3a69 to 8bfec2c7ed43 (2 revisions) (flutter/engine#48683) 2023-12-05 [email protected] Update labeler to 5.0.0, fix yaml format for labeler 5.0.0 (flutter/engine#48682) 2023-12-05 [email protected] [Impeller] Make Entity move only, simplify construction of geometry/filter contents. (flutter/engine#48596) 2023-12-05 [email protected] [Impeller] Delete tessellation control/eval shader support. (flutter/engine#48649) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no plans to ever use these for anything.