Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

A11y enabled state #48653

Merged
merged 4 commits into from
Dec 5, 2023
Merged

A11y enabled state #48653

merged 4 commits into from
Dec 5, 2023

Conversation

jrwang
Copy link
Contributor

@jrwang jrwang commented Dec 5, 2023

Sets enabled state in Fuchsia a11y via the accessibility bridge.

This was added in Fuchsia API v15, which Flutter is updated to use after #48233.

b/261482081

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@jrwang jrwang requested a review from CaseyHillers December 5, 2023 04:10
@CaseyHillers CaseyHillers requested review from apwilson and removed request for CaseyHillers December 5, 2023 17:29
Copy link
Contributor

@apwilson apwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrwang jrwang merged commit cfdaecc into main Dec 5, 2023
@jrwang jrwang deleted the a11y-enabled-state branch December 5, 2023 18:17
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 5, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 5, 2023
…139583)

flutter/engine@7133378...cfdaecc

2023-12-05 [email protected] A11y enabled state (flutter/engine#48653)
2023-12-05 [email protected] Roll Skia from bf1db1c75704 to c0ad3e9bdec0 (1 revision) (flutter/engine#48685)
2023-12-05 [email protected] [Impeller] started taking into account integer gaps in blur sigma, turned on linear filter (flutter/engine#48651)
2023-12-05 [email protected] Roll Dart SDK from 21574eae3a69 to 8bfec2c7ed43 (2 revisions) (flutter/engine#48683)
2023-12-05 [email protected] Update labeler to 5.0.0, fix yaml format for labeler 5.0.0 (flutter/engine#48682)
2023-12-05 [email protected] [Impeller] Make Entity move only, simplify construction of geometry/filter contents. (flutter/engine#48596)
2023-12-05 [email protected] [Impeller] Delete tessellation control/eval shader support. (flutter/engine#48649)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants