This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" #49336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update tests to conform to the render rule.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 22, 2023
…140527) flutter/engine@1b1b2a1...737e6f8 2023-12-21 [email protected] Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343) 2023-12-21 [email protected] Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336) 2023-12-21 [email protected] Turn on scenario app screenshots (flutter/engine#49066) 2023-12-21 [email protected] Revert onrender change (flutter/engine#49333) 2023-12-21 [email protected] [web] autofocus in new routes (flutter/engine#47727) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 27, 2023
…40678) Re-enables skipped flaky test now that the underlying cause of flakiness (GPU memory leak) has been fixed in the engine and the fix has rolled into the framework. The fix is here: flutter/engine#49336 Fixes #137669
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140527) flutter/engine@1b1b2a1...737e6f8 2023-12-21 [email protected] Roll Dart SDK from bcf68d22f0fa to fe94d9b88531 (1 revision) (flutter/engine#49343) 2023-12-21 [email protected] Reland "[web] Enforce onDrawFrame/onBeginFrame render rule" (flutter/engine#49336) 2023-12-21 [email protected] Turn on scenario app screenshots (flutter/engine#49066) 2023-12-21 [email protected] Revert onrender change (flutter/engine#49333) 2023-12-21 [email protected] [web] autofocus in new routes (flutter/engine#47727) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…utter#140678) Re-enables skipped flaky test now that the underlying cause of flakiness (GPU memory leak) has been fixed in the engine and the fix has rolled into the framework. The fix is here: flutter/engine#49336 Fixes flutter#137669
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforces the render rule on the web except in the HTML renderer, which must still render to the DOM even outside of
onDrawFrameoronBegineFramescopes in order for golden tests to continue to work in the framework.This is a reland of #49214 with one change (checking for
renderer.rendererTag == 'html'in therendermethod).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.