This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Add view ID runner APIs #51020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Feb 27, 2024
| @@ -32,6 +32,9 @@ typedef struct FlutterDesktopView* FlutterDesktopViewRef; | |||
| struct FlutterDesktopEngine; | |||
| typedef struct FlutterDesktopEngine* FlutterDesktopEngineRef; | |||
|
|
|||
| // The unique identifier for a view. | |||
| typedef int64_t FlutterDesktopViewId; | |||
There was a problem hiding this comment.
This FlutterDesktopViewId typedef is new, the design doc used int64_t directly.
loic-sharma
commented
Feb 27, 2024
| @@ -9,6 +9,9 @@ | |||
|
|
|||
| namespace flutter { | |||
|
|
|||
| // The unique identifier for a view. | |||
| typedef int64_t FlutterViewId; | |||
There was a problem hiding this comment.
This FlutterViewId typedef is new, the design doc used int64_t directly.
loic-sharma
changed the title
yaakovschectman
approved these changes
Feb 28, 2024
loic-sharma
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
…144405) flutter/engine@7b3ef43...1f24eaa 2024-02-29 [email protected] Reapply "Bump everything to Android 21" (#51056) (flutter/engine#51070) 2024-02-29 [email protected] [Windows] Add view ID runner APIs (flutter/engine#51020) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Flutter Windows apps and plugins to get the view's ID.
Design doc: https://flutter.dev/go/desktop-multi-view-runner-apis
Part of flutter/flutter#143767
Part of flutter/flutter#142845
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.