This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Windows] Add view ID runner APIs #51020
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,9 @@ typedef struct FlutterDesktopView* FlutterDesktopViewRef; | |
struct FlutterDesktopEngine; | ||
typedef struct FlutterDesktopEngine* FlutterDesktopEngineRef; | ||
|
||
// The unique identifier for a view. | ||
typedef int64_t FlutterDesktopViewId; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This |
||
|
||
// Properties for configuring a Flutter engine instance. | ||
typedef struct { | ||
// The path to the flutter_assets folder for the application to be run. | ||
|
@@ -97,13 +100,17 @@ FlutterDesktopViewControllerCreate(int width, | |
FLUTTER_EXPORT void FlutterDesktopViewControllerDestroy( | ||
FlutterDesktopViewControllerRef controller); | ||
|
||
// Returns the view controller's view ID. | ||
FLUTTER_EXPORT FlutterDesktopViewId FlutterDesktopViewControllerGetViewId( | ||
FlutterDesktopViewControllerRef view_controller); | ||
|
||
// Returns the handle for the engine running in FlutterDesktopViewControllerRef. | ||
// | ||
// Its lifetime is the same as the |controller|'s. | ||
FLUTTER_EXPORT FlutterDesktopEngineRef FlutterDesktopViewControllerGetEngine( | ||
FlutterDesktopViewControllerRef controller); | ||
// Returns the view managed by the given controller. | ||
|
||
// Returns the view managed by the given controller. | ||
FLUTTER_EXPORT FlutterDesktopViewRef FlutterDesktopViewControllerGetView( | ||
FlutterDesktopViewControllerRef controller); | ||
|
||
|
@@ -205,7 +212,7 @@ FLUTTER_EXPORT void FlutterDesktopEngineSetNextFrameCallback( | |
|
||
// ========== View ========== | ||
|
||
// Return backing HWND for manipulation in host application. | ||
// Returns the backing HWND for manipulation in host application. | ||
FLUTTER_EXPORT HWND FlutterDesktopViewGetHWND(FlutterDesktopViewRef view); | ||
|
||
// Returns the DXGI adapter used for rendering or nullptr in case of error. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
FlutterViewId
typedef is new, the design doc usedint64_t
directly.