Only print "gclient sync" warning once during rebase #52133
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @zanderso |
jmagman
added
the
autosubmit
…146841) flutter/engine@bb127fe...4d69c0c 2024-04-16 [email protected] Only print "gclient sync" warning once during rebase (flutter/engine#52133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#146841) flutter/engine@bb127fe...4d69c0c 2024-04-16 [email protected] Only print "gclient sync" warning once during rebase (flutter/engine#52133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| @@ -10,6 +10,9 @@ const String _reset = '\x1B[0m'; | |||
| /// Prints a reminder to stdout to run `gclient sync -D`. Uses colors when | |||
| /// stdout supports ANSI escape codes. | |||
| void printGclientSyncReminder(String command) { | |||
| if (command == 'pre-rebase') { | |||
There was a problem hiding this comment.
It would be cleaner to just remove the call to this function from https://github.com/flutter/engine/blob/main/tools/githooks/lib/src/pre_rebase_command.dart#L19, I think.
There was a problem hiding this comment.
Ah yes that would be better, let me fix it. Thanks @zanderso
Remove `pre-rebase` check from `gclient sync` warning, and instead remove the warning call from `pre_rebase_command` Follow-up to #52133 (comment)
Skip the "pre-rebase" message since it will also be printed "post-checkout" at the end.
Fixes flutter/flutter#146781
Before this PR:
On this PR it's only printed once
Fixes flutter/flutter#146781